Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokioBinProcess - stray processes are sometimes left around #983

Closed
rukai opened this issue Dec 22, 2022 · 2 comments
Closed

TokioBinProcess - stray processes are sometimes left around #983

rukai opened this issue Dec 22, 2022 · 2 comments

Comments

@rukai
Copy link
Member

rukai commented Dec 22, 2022

I suspect the solution may look like registering a sigint handler so that we ensure the child process is killed before terminating.

Note that we are already making use of this: https://docs.rs/tokio/latest/tokio/process/struct.Command.html#method.kill_on_drop

@rukai
Copy link
Member Author

rukai commented Feb 6, 2023

I actually havent seen this since I raised the issue, maybe it got accidentally fixed?
I'll leave it open for a while longer to see if it occurs again.

@rukai
Copy link
Member Author

rukai commented Mar 15, 2023

Yep, I havent seen this again since reporting, I think it was fixed.

@rukai rukai closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant