Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self.objective seems not used #28

Closed
Naruto-Sasuke opened this issue Dec 12, 2022 · 1 comment
Closed

self.objective seems not used #28

Naruto-Sasuke opened this issue Dec 12, 2022 · 1 comment

Comments

@Naruto-Sasuke
Copy link

total_timesteps, sampling_timesteps, eta, objective = self.num_timesteps, self.sampling_timesteps, self.ddim_sampling_eta, self.objective

@ShoufaChen
Copy link
Owner

Good catch! Thank you.

objective can be predicting $x_0$ and or added noise. We use $x_0$ in this work.

More details can be found in https://github.com/lucidrains/denoising-diffusion-pytorch/blob/main/denoising_diffusion_pytorch/denoising_diffusion_pytorch.py#L544-L552.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants