Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShouldMatchApproved opens multiple instances of difftool #388

Closed
dennisroche opened this issue Jun 24, 2016 · 4 comments
Closed

ShouldMatchApproved opens multiple instances of difftool #388

dennisroche opened this issue Jun 24, 2016 · 4 comments
Milestone

Comments

@dennisroche
Copy link

Recently had 75+ instances of Beyond Compare open as all the tests failed.

Beyond Compare and KDiff both support opening multiple files or directory comparison.

I'm not sure how I would implement this yet... but it would be nice if diffs are opened at the end of the test run.

@dennisroche
Copy link
Author

Two possible options.

  1. AppDomain.Unload to determine when the tests have finished.
  2. Limit the number of diffs opened, e.g. 5.

@SimonCropp
Copy link
Contributor

@dennisroche
Copy link
Author

DiffRunner.MaxInstancesToLaunch(5); helps solve the problem without having to mess about with AppDomain.Unload

Happy to close.

@dennisroche
Copy link
Author

dennisroche commented Jul 10, 2020

🤦‍♂️ that was in another project.

yes, we should copy that approach or perhaps even better integrate with DiffEngine. i'm happy to pick this up and fix.

@SimonCropp SimonCropp added this to the 4.0.0 milestone Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants