Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Skip connection should be always added to DW branches. #9

Closed
grygielski opened this issue Aug 11, 2022 · 2 comments
Closed

[BUG] Skip connection should be always added to DW branches. #9

grygielski opened this issue Aug 11, 2022 · 2 comments

Comments

@grygielski
Copy link

grygielski commented Aug 11, 2022

Hi @shoutOutYangJie, I've noticed that you have a bug in your MobileOne implementation:

self.dw_bn_layer = nn.BatchNorm2d(in_channels) if out_channels == in_channels and stride == 1 else None

You are adding DW BN layer based on in_channels == out_channels condition but it should be always added because for DW part input channels are always equal to output channels. This condition should be only checked for PW part as there might be channel change.

@shoutOutYangJie
Copy link
Owner

Oh, yes, thank you. I will refer your issue to ReadMe. Because I don't plan to retrain the model, so I don't want to rewrite it.
Thank you again.

@shoutOutYangJie
Copy link
Owner

and the official mobileone source code has been opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants