Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showdown editor demo uses 'h3' as top-level headings. #194

Closed
twitwi opened this issue Aug 26, 2015 · 3 comments
Closed

Showdown editor demo uses 'h3' as top-level headings. #194

twitwi opened this issue Aug 26, 2015 · 3 comments

Comments

@twitwi
Copy link
Contributor

twitwi commented Aug 26, 2015

In relation the feature from #69 (which is great), as a newcomer, I've been confused with the fact that the demo uses h3 for first level headings.

I don't know the project enough to know if this must be changed or not. The best would probably to show the option in the side panel of the demo.

@tivie
Copy link
Member

tivie commented Aug 26, 2015

The demo Uses h3 for design purposes. Showdown uses h1 by default and you can chance that behaviour thoughts options. It's explained in the documentation.

@twitwi
Copy link
Contributor Author

twitwi commented Aug 26, 2015

Thanks for your answer. I had seen the option motivated by #69 (the option is really useful, h1 vs h3 actually mattered a lot in my use case).
I'll try to see if I can provide a pull request to update the demo (adding the option, but leaving it to 3 by default) to help first-time explorers like me not get confused (as the demo acts also as a documentation).
Feel free to close this issue as I'm not sure if the PR will come soon.

@tivie
Copy link
Member

tivie commented Aug 26, 2015

@twitwi Ah! I see. I think you're right, people might get confused. I will close this issue and open a new one in the demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants