Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unordered List with Headings #495

Closed
limaneto opened this issue Jan 27, 2018 · 2 comments
Closed

Unordered List with Headings #495

limaneto opened this issue Jan 27, 2018 · 2 comments
Assignees

Comments

@limaneto
Copy link

Hi, thanks for providing this lib !!
I think I spotted a minor bug.
The last heading does not get converted to a Heading after running makeHtml function.

screen shot 2018-01-27 at 13 57 03

screen shot 2018-01-27 at 13 56 30

@tivie tivie self-assigned this Jan 27, 2018
@tivie
Copy link
Member

tivie commented Jan 27, 2018

humm... This one is "interesting".

The "correct" way of doing this should be:

- Increase the number of water changes.

- #### Protein skimmers:

    This remove dissolved...

- #### Chemical filter media:

    When placed in your filter, ...

Why? Because in lists, blocks should be separated by an empty line and indented four spaces. (Both header and paragraph are blocks)

Outside lists, blocks should also be separated by an empty line. The only exception to this rule are headers.

So, you have 2 syntax rules that clash with eachother.

IMHO, users expect that headers, in this regard, work the same way inside and outside list blocks.

So we probably should treat this as a "bug" (mostly because GFM supports your syntax style)

@tivie
Copy link
Member

tivie commented Sep 15, 2018

Should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants