-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config for shower #10
Comments
By the way, if we want to implement the creation of themes, the config will help to determine what we are working with |
I always thought that configs are not the best UI. Especially for Shower where the number of options is pretty limited. Theme and ratio? That’s just not worth it. Have you tried np package? I use it for publishing npm packages. I’d rather use something like this where utility asks you some questions instead of flags or configs.
It looks so much easier than having (another) extra file in your folder or specifying flags. |
Yes, I agree that it is not necessary to complicate infrastructure. Talking about the stages of build, like I have an example. Now you are ready to remove the build from the main repository and completely replace it with the CLI. The problem is that I don't know how to specify the list of files that should be in the I see an optional build configuration file not as a replacement for the current infrastructure, but as an extension of the build capabilities. In my example I would add in a |
Why not make it a flag? Because parameters like |
Instead of configs, I’d rather focus on smart defaults or prompts. It’s always better to follow the user’s needs, not abstract configurability. Let’s follow use cases ;) BTW, have you seen prompts package? |
Now I offer a list of settings as in np, and tried to put down the most convenient default settings. But it's still not always convenient. For example, now for each run of prepare/archive/publish, you must specify a list of files with a flag. I don't think it's very convenient. prompts is an interesting package, but how can it help? |
I think it's too early to think about the config. Config is needed when there are too many settings. We can try to collect all possible settings and then think about the config. :) |
By smart defaults, I mean relying on the existing folder structure: in shower/shower case and prepare/archive tasks it’s everything, but [config files]. It should cover 90% of cases, for the rest 8% flags will work better, 2% of cases might be better with config. But I’d cover and test 98% first, instead of focusing on 2%. |
Decided what to do the config is overkill |
Since version 2.0 the main functions are implemented:
create
,archive
,prepare
,save
,publish
andpdf
. Each of these functions can be configured, for example, for prepare, you can specify the folder in which the project will be built and for pdf file name. Now these parameters are set by default and can be overridden by flags. But it's not flexible enough. What if I want a pdf file always calledbest_press.pdf
or rename index.html inpresentation.html
?The second problem is that some functionality is not needed by everyone, but would be useful in the form of plugins, such as code highlighting
I propose to look at the solution from
webpack@4
and implement a configuration file for presentations, asshower.config.js
. In order not to overcomplicate projects, if the config is not set, the default settings will be used, but if additional features are required, the user can flexibly configure the project.The text was updated successfully, but these errors were encountered: