This repository has been archived by the owner on Mar 5, 2023. It is now read-only.
Set DYLIB_INSTALL_NAME_BASE to @rpath #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What a fantastic catch, thanks a lot Tony! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some trouble using MASShortcut alongside
@IBDesignablein Xcode tonight, and noticed that theINSTALL_PATHhad been hard-coded to"@executable_path/../Frameworks"and theDYLIB_INSTALL_NAME_BASEwas defaulting to/Library/Frameworks.Since Mac OS X 10.5, setting
DYLIB_INSTALL_NAME_PATHto@rpathhas been the preferred setting - this allows apps and other frameworks to ask the dynamic linker to search a specific list of locations (set using theLD_RUNPATH_SEARCH_PATHSvariable), rather than hard coding the list of places into the library.There's more info at https://www.mikeash.com/pyblog/friday-qa-2009-11-06-linking-and-install-names.html, but it resolved the Interface Builder issues I was having, and these settings are the defaults when you create a new macOS framework project in Xcode 8 so they should be reasonably safe to include.