Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to display category/tag title instead of slug? #59

Closed
mingxia opened this issue Sep 5, 2015 · 16 comments
Closed

how to display category/tag title instead of slug? #59

mingxia opened this issue Sep 5, 2015 · 16 comments

Comments

@mingxia
Copy link
Contributor

mingxia commented Sep 5, 2015

In addition to English, such as Chinese, title of category and tag is chinese(not english), but in order to optimize the url, slug is usually set to English or pinyin ,but now the title of single category and tag is display: slug , For the reader, is not very intuitive.

code is here:
https://github.com/shprink/wordpress-hybrid-client/blob/develop/lib/taxonomies/taxonomies.service.coffee#L40

how i can change to let the {{name}} show category/tag title directly?

@pinkasey
Copy link

pinkasey commented Aug 26, 2016

I came across the same issue, and I have the fix merged to my branch.
My problem now is that when I click a category, I get the name of the category, but it's http-encoded.

I've tried debugging this myself, and got as deep as angular-translate.js ($translateInterpolator.interpolate()) - interpolatedText = $translateSanitization.sanitize(interpolatedText, 'text');
I'm new to NodeJS, so I hardly understand what i'm reading there.

Here are some screenshots:
Categories page loads well - it shows category names (not slug):
screen shot 2016-08-26 at 23 54 30
first category is called "פרות", which mean "cows"

Clicking the first category (as seen bellow), shows פרות instead of "פרות"
screen shot 2016-08-26 at 23 24 24

@pinkasey
Copy link

pinkasey commented Aug 26, 2016

I'd be happy to contribute by solving this, but I could use some guidance.

@mingxia
Copy link
Contributor Author

mingxia commented Aug 27, 2016

thanks,this issue i cann‘t solved,i will see u branch, great!

@dshamenkov
Copy link

@pinkasey @shprink I have the same problem... Please, help us to solve it...

@shprink
Copy link
Collaborator

shprink commented Sep 16, 2016

@dshamenkov please share with me:

  • your ap-api link
  • the page where you see the problem
  • the expected result

@shprink shprink reopened this Sep 16, 2016
@dshamenkov
Copy link

Dear Julien, thank you so much for your quick reply!
I use the last version of your great WHC and I didn't change the code.

So, when I open categories list, categories showed in correct way (all of
them in russian):
https://www.dropbox.com/s/oruhfcju5wlflh7/categories_list.png

But! When I choose one category, the title showed in decimals:
https://www.dropbox.com/s/qymz5arm7dkwqmm/one_category_from_list.png

So, it will be better to show in title the name of category like in the
list.

Then, if I choose category from menu (for example, "Relations"), it opened
with slug-name of category, not with real category name in Russian:
https://www.dropbox.com/s/lpcfprhjxh4l347/category_from_menu.png

In all cases I used the same category (Relations, in russian - "Отношения")

So, better choice is to show real name of category in the title of the
single category page, opened from menu...

And the next problem with authors page the same to described before with
categories:

when I opened page with authors list - all names showed in russian
correctly:
https://www.dropbox.com/s/d2zgbm8v96tkyes/authors_list.png

But, if I choose single author - the name of author showed in title in
decimals - and it will be better to show the name correctly:
https://www.dropbox.com/s/9si2cta5cldbu6o/single_author.png

Thank you so much for a great job. Im just beginner, and you really help me
to start...
Yours, Dmitry

2016-09-16 17:20 GMT+07:00 Julien Renaux notifications@github.com:

@dshamenkov https://github.com/dshamenkov please share with me:

  • your ap-api link
  • the page where you see the problem
  • the expected result


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#59 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AR4Tcx1qs3XvnemWcEDH27mPcBHlL0zCks5qqm18gaJpZM4F4W9t
.

С уважением, Дмитрий Шаменков
Член Экспертной коллегии Фонда Сколково
Член Экспертного совета Фонда содействия развитию малых форм предприятий в
научно-технической сфере (Фонда Бортника)
SUZ.community, Founder

skype: dshamenkov
suz.community/id5

@shprink
Copy link
Collaborator

shprink commented Sep 17, 2016

Really well detailed, thanks. Please share your web api link so I can debug from home.

@dshamenkov
Copy link

Do you mean http://shamenkov.ru/wp-json ? or something else?
Im really novice - so sorry for misunderstanding in case....
Yours, Dmitry

2016-09-17 19:59 GMT+07:00 Julien Renaux notifications@github.com:

Really well detailed, thanks. Please share your web api link so I can
debug from home.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#59 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AR4Tc7dG3S-BP8E1DUABCGxuRZJ4mhwoks5qq-RNgaJpZM4F4W9t
.

С уважением, Дмитрий Шаменков
Член Экспертной коллегии Фонда Сколково
Член Экспертного совета Фонда содействия развитию малых форм предприятий в
научно-технической сфере (Фонда Бортника)
SUZ.community, Founder

skype: dshamenkov
suz.community/id5

@shprink
Copy link
Collaborator

shprink commented Sep 17, 2016

yes that's it. Will check 2morrow ;)

@dshamenkov
Copy link

Thank you so much......
Sincerely yours, Dmitry.

2016-09-17 22:48 GMT+07:00 Julien Renaux notifications@github.com:

yes that's it. Will check 2morrow ;)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#59 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AR4Tcx1nDv_kqETWpQKLGVdkrhcfVNqfks5qrAvlgaJpZM4F4W9t
.

С уважением, Дмитрий Шаменков
Член Экспертной коллегии Фонда Сколково
Член Экспертного совета Фонда содействия развитию малых форм предприятий в
научно-технической сфере (Фонда Бортника)
SUZ.community, Founder

skype: dshamenkov
suz.community/id5

@shprink
Copy link
Collaborator

shprink commented Sep 18, 2016

@dshamenkov please try the latests version beta12.

Run this to upgrade:

git checkout v2.0.0-beta12
rm -rf platforms/ plugins/ node_modules/
npm i
npm run restore

@mingxia
Copy link
Contributor Author

mingxia commented Sep 18, 2016

it's great!

@dshamenkov
Copy link

Dear Julien, thank you so much for reply!
I tried to run upgrade, but have received error:
error: pathspec 'v2.0.0-beta12' did not match any file(s) known to git.

2016-09-19 0:02 GMT+07:00 Julien Renaux notifications@github.com:

@dshamenkov https://github.com/dshamenkov please try the latests
version beta12.

Run this to upgrade:

git checkout v2.0.0-beta12
rm -rf platforms/ plugins/ node_modules/
npm i
npm run restore


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#59 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AR4Tc7QfalOt14d21BlJWN1yBD19u2OWks5qrW7AgaJpZM4F4W9t
.

С уважением, Дмитрий Шаменков
Член Экспертной коллегии Фонда Сколково
Член Экспертного совета Фонда содействия развитию малых форм предприятий в
научно-технической сфере (Фонда Бортника)
SUZ.community, Founder

skype: dshamenkov
suz.community/id5

@shprink
Copy link
Collaborator

shprink commented Sep 20, 2016

git fetch --all before anything

@dshamenkov
Copy link

Oh, its really great! Thank you so much!

2016-09-20 14:46 GMT+07:00 Julien Renaux notifications@github.com:

git fetch --all before anything


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#59 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AR4Tc7EZFtB99kyNmNNIxv7ZvsEqnL7zks5qr49bgaJpZM4F4W9t
.

С уважением, Дмитрий Шаменков
Член Экспертной коллегии Фонда Сколково
Член Экспертного совета Фонда содействия развитию малых форм предприятий в
научно-технической сфере (Фонда Бортника)
SUZ.community, Founder

skype: dshamenkov
suz.community/id5

@pinkasey
Copy link

Awesome!
Thank you so much for fixing this!

pinkasey pushed a commit to pinkasey/activegan that referenced this issue Oct 4, 2016
pinkasey pushed a commit to pinkasey/activegan that referenced this issue Oct 4, 2016
pinkasey pushed a commit to pinkasey/activegan that referenced this issue Feb 20, 2017
pinkasey pushed a commit to pinkasey/activegan that referenced this issue Feb 20, 2017
pinkasey added a commit to pinkasey/activegan that referenced this issue May 18, 2018
added default config.cson
(cherry picked from commit 3a1eab2)

committing default config.xml
(cherry picked from commit 634daf3)

config.xml that works

add hebrew

change preferred language to hebrew

add icon and splash-screen

ignore DS_Store files - they belong to CrashPlan i think. On my new Mac

Adding siksik to the list :)

Update zh.cson

Add four words:ru、tr、enabled、pushNotifications,fix three words!

Resolving issue wordpress-clients#221

Resolving issue wordpress-clients#221

bump beta09

hebrew working, changed menu, overide some templates, added files to repository
changed .gitignore, which might be a mistake, and i'll look into that

clean up menue, posts seem to work fine, still need to set order

Adding missing  !default

Adding Trou Idees TI app

Update AbstractItemService.js

Update AbstractListService.js

Add the taxonomy term to the cache same modification to file AbstractItemService.js

adding the way to update the font

Adding some more ios apps!

another great app!

upgrade to android API-23

keeping an iOS implementation of notif count for reference

update crosswalk

bump

added keystore

vidoes are now pressented in post list, so there is no need to open post. Ive tried narrowing the "access" and "allow-navigation urls, but then the videos didnt play. need to play with this more."

push notification and package change

Update AbstractItem.js

The post is not refreshed after a pull to refresh
Below is the modification in line 22 to clear the cache :
this.service.clearCache();

Changed the dutch translations, removed a typo and added new strings!

Adding another great app: CommonTales

Two new apps!

adding missing command

new iOS app

update Prerequisites versions

new android app

preparing beta11

use templates for author/authors views

fix wordpress-clients#59 encoding problem

Fetching categorie/tag/custom names from post list to update page title

remove native transitions

ios 10 ready

fix wordpress-clients#59 encoding problem in my posts-list.html

support orderby menu_order

order posts by menu_order, when choosing category

upped the version for fixing post order issue when choosing category

overriding categories list template, to add image to each category

category images

New embedded path. Closes wordpress-clients#279

Author -> Autor

Author is in German: Autor
Plural: Autors -> Autoren

adding docs for a new issue wordpress-clients#278

Custom Menu Logo

Cleanup

Prep for dist

Update config.default.cson

Logo Image in /config/logo.png

forgot default

adding manifest for progressive web apps

adding serviceWorker support. Disabled by default

service workers docs

remove share button when on browser

bump beta13

use https version of my web service

Fix Pagination on customPosts. Closes wordpress-clients#283

Update Build,md

Typo error

Update Dutch Translations

While using the app I noticed some translations were not in context or inline with WordPress translations. Changed those!

custom post and custom taxo queries are customizale through the conf. Closes wordpress-clients#288

add a scss variable for the menu bar title with icon

bump beta 14

migrate to yarn

Removes ES6 code that needs a polyfill

bump beta15 due to a critical bug...

Replace baseUrl http:// with https://

Fix this error on first start :

```XMLHttpRequest cannot load https://dev.julienrenaux.fr/wp-json/... The 'Access-Control-Allow-Origin' header has a value 'http://null' that is not equal to the supplied origin. Origin 'null' is therefore not allowed access.```

Update Build.md

Typo error

add new iOS app

upgrade cordova-ios and cordova-android

add more logs for admobs

upgrade crosswalk

bump beta16

Update AbstractItem.js

The post is not refreshed after a pull to refresh
Below is the modification in line 22 to clear the cache :
this.service.clearCache();

Changed the dutch translations, removed a typo and added new strings!

Adding another great app: CommonTales

Two new apps!

adding missing command

new iOS app

update Prerequisites versions

new android app

preparing beta11

use templates for author/authors views

fix wordpress-clients#59 encoding problem

Fetching categorie/tag/custom names from post list to update page title

remove native transitions

ios 10 ready

New embedded path. Closes wordpress-clients#279

Author -> Autor

Author is in German: Autor
Plural: Autors -> Autoren

adding docs for a new issue wordpress-clients#278

Custom Menu Logo

Cleanup

Prep for dist

Update config.default.cson

Logo Image in /config/logo.png

forgot default

adding manifest for progressive web apps

adding serviceWorker support. Disabled by default

service workers docs

remove share button when on browser

bump beta13

use https version of my web service

Fix Pagination on customPosts. Closes wordpress-clients#283

Update Build,md

Typo error

Update Dutch Translations

While using the app I noticed some translations were not in context or inline with WordPress translations. Changed those!

custom post and custom taxo queries are customizale through the conf. Closes wordpress-clients#288

add a scss variable for the menu bar title with icon

bump beta 14

migrate to yarn

Removes ES6 code that needs a polyfill

bump beta15 due to a critical bug...

Replace baseUrl http:// with https://

Fix this error on first start :

```XMLHttpRequest cannot load https://dev.julienrenaux.fr/wp-json/... The 'Access-Control-Allow-Origin' header has a value 'http://null' that is not equal to the supplied origin. Origin 'null' is therefore not allowed access.```

Update Build.md

Typo error

add new iOS app

upgrade cordova-ios and cordova-android

add more logs for admobs

upgrade crosswalk

bump beta16

bump 2.0.0

Adding docs about how to use crosswalk lite

adding accordion!

forgot to mention crosswalk version

update prerequisites

Fix typo showing MD file on Github

Fix typo on Google

Fix typos on BUILD.md

Fix Debug command

Update pt translation

new app

Open links in a comment in Safari

Links in a comment open in app and not in Safari / default Browser. Adding prepLink to commentCtrl.comment.content.rendered fix this issue.

update cordovaPlugins version

i tested these newest Plugins on Android and IOS, all is right!

WordPress 4.7 ready. Closes wordpress-clients#308

bump 2.0.0

wp 4.7 ready

tmp before rebase with upstream

fix error css about wp-caption

now image in post can show center!

Update CHANGELOG.md

Update CHANGELOG.md

update dependencies,tested it!

now no “Can't run npm run restore” questions,byebye ionic.project!

rollback cordova plugin upgrade (until fixed)

bump 2.0.1

rebased to comply with wp 4.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants