Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of support for ssl #1

Closed
przemyslaws-iRonin opened this issue Oct 18, 2017 · 5 comments
Closed

Lack of support for ssl #1

przemyslaws-iRonin opened this issue Oct 18, 2017 · 5 comments

Comments

@przemyslaws-iRonin
Copy link

When url to the remote file is specified by https protocol then EOFError: end of file reached is raised from the Net::HTTP

@janko
Copy link
Member

janko commented Oct 18, 2017

Can you try to come up with a self-contained example that reproduces the problem, or at least the URL for which you're getting this exception and the backtrace of the exception?

@przemyslaws-iRonin
Copy link
Author

Problematic url is https://kbob.github.io/images/sample-3.jpg.

After enabling ssl in #request method everything works properly
Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https') do |http|

@janko
Copy link
Member

janko commented Oct 18, 2017

@przemyslaws-iRonin To confirm, this error occurs when #exists? or #delete storage method is called? Because #download and #open are using the Down gem, which should have correct SSL handling.

@janko
Copy link
Member

janko commented Oct 18, 2017

Ok, I've managed to reproduce the issue, and am pushing a fix.

@przemyslaws-iRonin
Copy link
Author

It was for #exists? method

@janko janko closed this as completed in 115f46d Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants