Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubinius does not like "multipart: {file: image}" in tests. #29

Closed
jasnow opened this issue Dec 27, 2015 · 2 comments
Closed

Rubinius does not like "multipart: {file: image}" in tests. #29

jasnow opened this issue Dec 27, 2015 · 2 comments

Comments

@jasnow
Copy link

jasnow commented Dec 27, 2015

Rubinius does not like "multipart: {file: image}" in shrine's tests.

We are getting following error 9+1 (10) times in one test file, direct_upload_test.rb, on Travis:

To reproduce it, I change my rvm locally to "rvm install rbx-2.9" and ran "bundle"/"rake" and got same results.

You can also run this: "rake test TEST=test/plugin/direct_upload_test.rb".

Question: Is there another way to specify the "multipart: {file: image}" in this file: test/plugin/direct_upload_test.rb"?

Here is the line in the rack-test_app gem: lib/rack/test_app.rb:230: * v.is_a?(::File) ? mp.add_file(k, v) : mp.add(k, v.to_s)

@janko
Copy link
Member

janko commented Dec 28, 2015

Thanks, I've already isolated the bug before, and raised an issue on Rubinius (rubinius/rubinius#3544). I've tried to see if that part in rack-test_app can be written a bit differently, but it would have to be a big change.

I will make these tests pending for Rubinius for now, until it is resolved and a new Rubinius version is released.

@janko janko closed this as completed in 4936896 Dec 28, 2015
@jasnow
Copy link
Author

jasnow commented Dec 29, 2015

Thanks for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants