Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cv2.COLOR_BGR2RGB is missing at get_identity_descriptor? #31

Closed
khlee369 opened this issue Jul 28, 2021 · 2 comments
Closed

cv2.COLOR_BGR2RGB is missing at get_identity_descriptor? #31

khlee369 opened this issue Jul 28, 2021 · 2 comments

Comments

@khlee369
Copy link

At get_identity_descriptor.compute_pose_identity_error.py,

if the face detection gets failed, it manually crops and pre-processes the image.
and there is no channel conversion(BGR to RGB)

but if face detection gets succeed, arcface_model.get_input(image) convert image channels.link

i think cv2.cvtColor(image_cropped, cv2.COLOR_BGR2RGB) is needed when image_cropped is None

@shrubb
Copy link
Owner

shrubb commented Jul 29, 2021

Maybe, not sure. Anyway, if a face isn't detected (which already happens quite rarely), then the match score is going to be so large that BGR/RGB won't matter much.
Thanks for the comments.

@khlee369
Copy link
Author

Thank you for the reply! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants