Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OxiPNG stopped working on Windows 7 #617

Closed
sergeevabc opened this issue Apr 30, 2024 · 10 comments
Closed

OxiPNG stopped working on Windows 7 #617

sergeevabc opened this issue Apr 30, 2024 · 10 comments

Comments

@sergeevabc
Copy link

Windows 7 x64.

OxiPNG 9.0.0 works fine, 9.1.0 does not.

2024-0430-1353 oxipng 910 error

@andrews05
Copy link
Collaborator

Hi @sergeevabc
Sorry to hear this. Can you post the file you're trying to optimise and the options you're using?

@sergeevabc
Copy link
Author

@andrews05, it's not related to any graphic file, the app just refuses to run as is.

Perhaps Rust developers decided to betray Windows 7 users and the new version of the compiler simply does not allow you to make an executable file for this OS.

@andrews05
Copy link
Collaborator

andrews05 commented May 1, 2024

It seems you are correct: rust-lang/compiler-team#651
Windows 7 support was dropped in Rust 1.76, so our automated builds will no longer work on "legacy" platforms.

That said, oxipng's current MSRV is 1.74, so it would be possible to build a compatible exe - you'd just have to do this yourself.

@sergeevabc
Copy link
Author

@andrews05, what do you mean “do it yourself”? I am a user, who is trained in another field, not a developer. This is your world, where I can only send signals.

@andrews05
Copy link
Collaborator

Apologies, I just mean that while it should be possible build v9.1 for Windows 7, this is not something we can provide for you. Someone could do it but the automated builds don't cater for this and I personally can't build for Windows myself.

You can of course continue to use v9.0 which is still a great version.
(Inevitably, some future release of oxipng will end up requiring Rust 1.76 or newer anyway, ruling out any possibility of building it for Windows 7.)

@AlexTMjugador
Copy link
Collaborator

I find it useful to note that the Rust compiler later gained Tier 3 (i.e., barely tested and supported) targets for Windows 7, though.

Anyway, adding Tier 3 targets to our CI opens a can of worms I'd prefer to keep closed. While the Rust compiler team does not have a strong reason to pull the plug for this Tier 3 target in particular for the time being, it's very likely that internal Rust changes end up introducing unintended dependencies on later Windows APIs that won't be noticed by anyone but final users, as there aren't any testing processes for Windows 7 anymore. I think that OxiPNG appearing to support Windows 7 when there's a non-negligible chance it really won't would cause even more frustration for both users and developers alike.

@enp6
Copy link

enp6 commented May 3, 2024

https://github.com/rust9x/rust
This project should receive more attention...

@AlexTMjugador
Copy link
Collaborator

rust9x is indeed interesting! For those willing to tinker with technical stuff, there's also ReactOS, an experimental OS that aims to achieve binary-compatibility with Windows applications and drivers, which at this point is arguably better supported by its creators than Windows 7.

Anyway, as stated above, I don't think it's in scope for OxiPNG to concern itself in an official capacity with targets that are effectively not supported by the build toolchain used. I'm closing this issue as not planned for now, but if there's anyone willing to go through what it takes to make Rust and, by proxy, OxiPNG well supported on Windows 7 again, please speak up and let us know for reopening this issue 👍

@AlexTMjugador AlexTMjugador closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024
@ace-dent
Copy link

ace-dent commented May 5, 2024

Useful post. Thanks!
I'm looking to bundle oxipng and assumed I could continue to support WinXP as a minimum OS supported. (Most other png CLI tools tolerate older Windows versions). Rust9x looks interesting... sadly I don't have time to experiment with this...

For the project, 32bit Win10 is an understandable minimum...

@AlexTMjugador
Copy link
Collaborator

I'm looking to bundle oxipng and assumed I could continue to support WinXP as a minimum OS supported.

For what it's worth, Rust hasn't supported Windows XP for years now, so if any recent OxiPNG version did ever work on XP it definitely was not intended. Did you ever have a chance of testing such a bundle with XP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants