Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrpcChannelOptions parameter configuration #171

Closed
SGStino opened this issue Nov 17, 2022 · 2 comments
Closed

GrpcChannelOptions parameter configuration #171

SGStino opened this issue Nov 17, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@SGStino
Copy link

SGStino commented Nov 17, 2022

Is your feature request related to a problem? Please describe.
I would like to set MaxReceiveMessageSize to a larger value, but since GrpcChannelOptions is created in the EtcdClient constructor, this is not possible.

Describe the solution you'd like
a Action<GrpcChannelOptions> configureChannelOptions = null parameter added to the constructor.
and configureChannelOptions?.Invoke(options) at


Describe alternatives you've considered
The whole GrpcChannelOptions object can't be passed into the constructor because the MethodConfigs, throttlingPolicy, handler, .. properties are set in the constructor already. And when passing in the entire object, you can't get those from the constructor.

And creating a custom configuration class with only the relevant properties, and copying them over sounds like wasted effort.

Additional context
Reason for changing the GrpcChannelOptions property:

Grpc.Core.RpcException: Status(StatusCode="ResourceExhausted", Detail="Received message exceeds the maximum configured message size.")
   at Grpc.Net.Client.StreamExtensions.ReadMessageAsync[TResponse](Stream responseStream, GrpcCall call, Func`2 deserializer, String grpcEncoding, Boolean singleMessage, CancellationToken cancellationToken)
   at Grpc.Net.Client.Internal.GrpcCall`2.RunCall(HttpRequestMessage request, Nullable`1 timeout)
   at dotnet_etcd.EtcdClient.<>c__DisplayClass49_0.<<GetAsync>b__0>d.MoveNext()
@shubhamranjan
Copy link
Owner

Thanks a lot for the suggestion. Will take this up.

@shubhamranjan shubhamranjan self-assigned this Nov 17, 2022
@shubhamranjan shubhamranjan added the enhancement New feature or request label Nov 17, 2022
@shubhamranjan shubhamranjan added this to To Do in dotnet-etcd via automation Nov 17, 2022
dotnet-etcd automation moved this from To Do to Done Nov 17, 2022
@shubhamranjan
Copy link
Owner

Thanks for reporting this. This has been released in 6.2.0-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
dotnet-etcd
  
Done
Development

No branches or pull requests

2 participants