Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @tailwind/typography #16

Open
shuding opened this issue Nov 12, 2020 · 5 comments
Open

Use @tailwind/typography #16

shuding opened this issue Nov 12, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@shuding
Copy link
Owner

shuding commented Nov 12, 2020

Let's use https://tailwindcss.com/docs/typography-plugin for article styling.

@shuding shuding added the enhancement New feature or request label Nov 12, 2020
@ng-hai
Copy link

ng-hai commented Feb 19, 2021

I think I can contribute to this, but not sure where to put the plugin. Should it live in its theme plugin or project's default tailwind.config.js?

@pacocoursey
Copy link
Collaborator

pacocoursey commented Feb 20, 2021

Best to add it to each theme individually @ng-hai, meaning here:
https://github.com/shuding/nextra/blob/core/packages/nextra-theme-docs/tailwind.config.js

Remember that core is the main development branch.

@ng-hai
Copy link

ng-hai commented Feb 22, 2021

I have added the plugin locally, and noticed these UI bugs

image

The code block background changed to dark.

image

image

List items appended new prefix.

image

image

Spacing and colors get wrong.

Should I change the MDX Components styles, or customize the plugin styles itself?

@shuding
Copy link
Owner Author

shuding commented Feb 22, 2021

I think it's better to change the styles of the components @ng-hai

@thien-do
Copy link
Contributor

thien-do commented Aug 7, 2021

Oh I just noticed that the "blog" theme already has this "typography" plugin :D only the "docs" is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants