Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting working perfectly but removes the theme colors. #56

Closed
iyashpal opened this issue Jan 28, 2021 · 20 comments
Closed

Formatting working perfectly but removes the theme colors. #56

iyashpal opened this issue Jan 28, 2021 · 20 comments
Labels
Stale Stale label

Comments

@iyashpal
Copy link

VS Code

Version: 1.52.1 (user setup)
Commit: ea3859d4ba2f3e577a159bc91e3074c5d85c0523
Date: 2020-12-16T16:34:46.910Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19042

Template

Happening in all blade files.

Context (Environment)

When extension is enabled:
image

When extension is disabled:
image

  • write your environment

This should not remove the colors from editor view. I thought the issue was from theme but after switching to several theme the issue remains the same.

Any other informations:

Current Theme I am using: Tokyo Night

@iyashpal
Copy link
Author

@shufo when I can get an update on this? I am eagerly waiting for this update so I can use it on regular basis. Please Please fix this.

@shufo
Copy link
Owner

shufo commented Mar 23, 2021

@iyashpal
Sorry for late reply.

It seems something affects your theme but vscode-blade-formatter do nothing for vscode color setting so tbh I can't figure out what was the issue.

I also tried Tokyo Night + vscode-blade-formatter but color theme seems correctly worked.

image

Can you give any more information?

e.g. extension list

$ code --list-extensions

@iyashpal
Copy link
Author

image

@iyashpal
Copy link
Author

I am using the windows OS

@iyashpal
Copy link
Author

@shufo I have disabled all the extensions and enabled only Blade Formatter but the error is same. Please check
image

@shufo
Copy link
Owner

shufo commented Mar 28, 2021

@iyashpal
ah, I might recognized. It seems your extension list have no syntax highlighter for blade. Since vscode-blade-formatter has no syntax highlighting feature so has to install highlighter separately like laravel-blade or Laravel Blade Snippets.

@iyashpal
Copy link
Author

Is it possible to have highlighting feature to the extension? Because I don't want to use extensions that are not useful for me.

Thank you

@shufo
Copy link
Owner

shufo commented Apr 4, 2021

Currently there is no plan to support highlight syntax because this project scope is limited to formatting template and existing extension like laravel-blade works properly. But if there is need to support highlight syntax with this extension, I'll take consider it!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Jun 4, 2021
@github-actions github-actions bot removed the Stale label Jun 13, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added Stale and removed Stale labels Aug 13, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Oct 15, 2021
@rogervila
Copy link

Hi, I have the same issue. Indentation works perfectly but HTML color scheme has disappeared.

image

@iyashpal
Copy link
Author

@iyashpal ah, I might recognized. It seems your extension list have no syntax highlighter for blade. Since vscode-blade-formatter has no syntax highlighting feature so has to install highlighter separately like laravel-blade or Laravel Blade Snippets.

@rogervila this is the only solution to this.

@rogervila
Copy link

@iyashpal ah, I might recognized. It seems your extension list have no syntax highlighter for blade. Since vscode-blade-formatter has no syntax highlighting feature so has to install highlighter separately like laravel-blade or Laravel Blade Snippets.

@rogervila this is the only solution to this.

Thank you! It works perfectly.

@github-actions github-actions bot removed the Stale label Oct 23, 2021
@MACscr
Copy link

MACscr commented Dec 13, 2021

Right, the problem isnt that we want the plugin to provide syntax highlighting, but that we dont want it to remove our themes built in highlighting features.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added Stale and removed Stale labels Feb 12, 2022
@sanskar-mk2
Copy link

Is it possible that the extension does not remove highlighting and only work as a "formatter". Thank you. I am aware that there is workaround for it as mentioned above, but it seemed hacky. It would be better user experience if our color/theme/linting stays intact when we install this extension.

@shufo
Copy link
Owner

shufo commented Apr 7, 2022

@sanskar-mk2
This Extension doesn't implement any Syntax Highlighting, so I don't know the cause of problem tbh, but it seems to have issue when installed with specific Extensions.

can you provide list of Extensions you have problem by running following command?

code --list-extensions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale Stale label label Jun 7, 2022
@whmountains
Copy link

The issue in my case was that blade was I Was missing the laravel blade snippets plugin. It would be awesome if the Readme could mention that this was required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Stale label
Projects
None yet
Development

No branches or pull requests

6 participants