Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing text color (w/b) for each background fill color. #5

Closed
hakunin opened this issue Feb 17, 2016 · 4 comments
Closed

Missing text color (w/b) for each background fill color. #5

hakunin opened this issue Feb 17, 2016 · 4 comments

Comments

@hakunin
Copy link

hakunin commented Feb 17, 2016

Hi,
one important piece thats missing here are the foreground colors (at least not present in the JSON file).
@shuhei
Copy link
Owner

shuhei commented Feb 18, 2016

Which one in the Material Design website do you mean? Do you mind giving me some examples?

@hakunin
Copy link
Author

hakunin commented Feb 18, 2016

Sure, if you look at the pallete, the colors have each either black or white text and this is different throughout the color scheme (blue's white text starts at 500, while indigo uses white from 300).
https://www.dropbox.com/s/dtk89mroi5z4maz/Screenshot%202016-02-18%2010.03.25.png?dl=0

@shuhei
Copy link
Owner

shuhei commented Feb 23, 2016

Got it! So they are either black or white of alpha 0.87. I'll think about how to encode the information to json, js and css variants. Thanks!

@felipemsantana felipemsantana mentioned this issue Aug 22, 2016
Merged
@shuhei
Copy link
Owner

shuhei commented Aug 4, 2018 •
edited

I assume that this was fixed by #8. Please feel free to reopen it if it's not.

@shuhei shuhei closed this as completed Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hakunin @shuhei