Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

关于孙辈节点的Bug #32

Closed
BetterWorld-Liuser opened this issue Jul 7, 2020 · 2 comments
Closed

关于孙辈节点的Bug #32

BetterWorld-Liuser opened this issue Jul 7, 2020 · 2 comments

Comments

@BetterWorld-Liuser
Copy link
Contributor

有个Bug,当to节点是from节点的孙辈的时候,也会移动过去,然后整个节点都没了,我稍微改进了一下hasInclude的代码。麻烦添加一下,另外我也pull request了另一个特性麻烦检查一下。

const hasInclude = (from, to) => {
  while(from.$parent!=undefined){
    if(from.$parent._uid === to._uid){
      return true
    }else{
      from = from.$parent
    }
  }
  return false
}
@shuiRong
Copy link
Owner

shuiRong commented Jul 8, 2020

👌,谢谢你提PR,晚上我才有空,然后跑一下看看。

@shuiRong
Copy link
Owner

shuiRong commented Jul 8, 2020

谢谢,It works. 已更新npm包

@shuiRong shuiRong closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants