Switch from Emotion to Vanilla-Extract #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
a0f8dd5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://49671b1d.svadilfari-checker.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from Emotion to Vanilla-Extract for styling.
While I personally like Emotion's API, it must be rendered using its provider and there's not much room for controlling how styles get injected. This is problematic in this project, as the way Emotion injects styles caused troubles (e.g. #33 ).
With vanilla-extract, we can choose how to apply the generated CSS. It seems that adding a style that
@importthe CSS file is not detected by Noir and therefore resolves #33.