Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% CPU after reading is aborted #256

Closed
Lithopsian opened this issue Jan 31, 2024 · 1 comment
Closed

100% CPU after reading is aborted #256

Lithopsian opened this issue Jan 31, 2024 · 1 comment

Comments

@Lithopsian
Copy link
Contributor

Press ctrl-S during a tree read to abort the read. CPU usage goes to 100%. This may not be noticeable at first as the gui is not blocked, but some actions such as opening a new dialog may become unresponsive.

The directory read queue runs off a zero-length timer. When a read is aborted, the queue is emptied but the timer is not stopped. It now fires continually with no other activity to slow it down.

A simple fix is to stop the timer when the queues are cleared. A more robust fix seems to be to stop the timer whenever the queue is found to be empty, although I haven't found any cases other than the abort that run out of control. I'll submit a pull request for that approach.

@shundhammer
Copy link
Owner

This should now be fixed with #257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants