Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align icon vertically #36

Open
shunjizhan opened this issue Sep 1, 2021 · 2 comments
Open

align icon vertically #36

shunjizhan opened this issue Sep 1, 2021 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@shunjizhan
Copy link
Owner

shunjizhan commented Sep 1, 2021

maybe switch to flex style to make icon align more accurate in the center

@shunjizhan shunjizhan added the enhancement New feature or request label Sep 1, 2021
@thejustinwalsh
Copy link

This solved the alignment problem for me:

const CaretRightIcon = ({ ...props }) => <span style={{ verticalAlign: 'middle', padding: '2px' }}><ChevronRight size={16} {...props} /></span>;
const CaretDownIcon = ({ ...props }) => <span style={{ verticalAlign: 'middle', padding: '2px' }}><ChevronDown size={16} {...props} /></span>;

@shunjizhan
Copy link
Owner Author

Hi Justin,

Thanks for sharing, it is super helpful for ppl who need to center icons with current version.

While using a custom icon is viable, I might update the default css in later version, so ppl won't need to custom all the icons just to align them in the middle lol

@shunjizhan shunjizhan changed the title style polish style polish (especially align icon vertically) Sep 3, 2021
@shunjizhan shunjizhan changed the title style polish (especially align icon vertically) align icon vertically Sep 3, 2021
@shunjizhan shunjizhan added the question Further information is requested label Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants