Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release #13

Open
schollz opened this issue Oct 3, 2017 · 2 comments
Open

Add release #13

schollz opened this issue Oct 3, 2017 · 2 comments

Comments

@schollz
Copy link

schollz commented Oct 3, 2017

Thanks @shurcooL for the great library! I was reading #12 because I was also having problems with dep. I managed to just modify my Gopkg.toml to use version 1.5 of blackfriday instead of 2.0. I was wondering, could you make a release of github_flavored_markdown so I can lock in the current version? This will help me stay locked in to what currently works, in case you plan on upgrading github_flavored_markdown to follow the new blackfriday v2.0.0.

@dmitshur
Copy link
Member

dmitshur commented Oct 5, 2017

I need to think about this before I can commit to using tags (and maintaining them for years to come). I currently only support the latest version of all my packages, see my SLA for more details.

I was wondering, could you make a release of github_flavored_markdown so I can lock in the current version? This will help me stay locked in to what currently works, in case you plan on upgrading github_flavored_markdown to follow the new blackfriday v2.0.0.

The problem of blackfriday v1 vs v2 is independent of normal versioning as it's supposed to work. They're supposed to have different import paths, but there's a bug/unintended behavior where the wrong package is being used at a given import path. It's being discussed and tracked in #12 (and parent issues).

I don't plan on upgrading github_flavored_markdown to use blackfriday v2 soon, but if I did, I would be sure the latest version of the package and its dependencies continues to work.

@spekary
Copy link

spekary commented Jul 30, 2021

I would like to echo the request to tag a release. It makes it much easier to depend on your project using a go.mod file.

By tagging a release, you are not committing to anything. It just makes it so that people can recreate builds using the tag, rather than a commit tag, which is much uglier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@spekary @dmitshur @schollz and others