Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: BaseProgress indeterminate state not working after commit 2215979 #112

Closed
mishamosher opened this issue Feb 17, 2024 · 0 comments
Closed

[Bug]: BaseProgress indeterminate state not working after commit 2215979 #112

mishamosher opened this issue Feb 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mishamosher
Copy link

The commit 2215979 breaks the indeterminate state functionality of the BaseProgress component.

If the type fix is really necessary, maybe a relaxed null check (using == instead of ===, and != instead of !==) here and here is a viable solution?
@mishamosher mishamosher changed the title [Bug]: progressindeterminate state not working after commit 2215979 [Bug]: BaseProgress indeterminate state not working after commit 2215979 Feb 17, 2024
@driss-chelouati driss-chelouati added the bug Something isn't working label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mishamosher @driss-chelouati