Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BaseListbox): allow value prop as model with v-model.prop #76

Merged
merged 4 commits into from
Aug 14, 2023
Merged

feat(BaseListbox): allow value prop as model with v-model.prop #76

merged 4 commits into from
Aug 14, 2023

Conversation

JohnCampionJr
Copy link
Contributor

@JohnCampionJr JohnCampionJr commented Aug 12, 2023

I need to use object ids in my listboxes, so I added this feature. Thought it'd be a nice addition.

Also added a test page to verify this works as expected.

I coded it as a non-breaking change.

@stafyniaksacha
Copy link
Contributor

Hello @JohnCampionJr

Thanks for the contribution, it's a good feature, we will add it to next release!

I would change it a bit to use model modifiers, so we can use it like <BaseListbox v-model.prop="" /> instead of having a boolean property (like in BaseInput here and here)

@JohnCampionJr
Copy link
Contributor Author

That's a nice tweak, I'll do that :)

@JohnCampionJr
Copy link
Contributor Author

All set!

@stafyniaksacha stafyniaksacha changed the title feat: allow value prop as model feat(BaseListbox): allow value prop as model with v-model.prop Aug 14, 2023
@stafyniaksacha stafyniaksacha merged commit 908e585 into shuriken-ui:release/next Aug 14, 2023
@JohnCampionJr JohnCampionJr deleted the listbox-value-prop branch September 30, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants