Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Floating UI for dropdown #94

Merged
merged 3 commits into from
Oct 3, 2023
Merged

feat: use Floating UI for dropdown #94

merged 3 commits into from
Oct 3, 2023

Conversation

JohnCampionJr
Copy link
Contributor

Allows for positioning near edges of pages correctly.

Can also allow for more props if you so desire around positioning and such.

@stafyniaksacha
Copy link
Contributor

Hello @JohnCampionJr

Thanks for your contribution, this is a great improvement!

Can you allow editing by maintainers? I would like to add the placement prop with fallback to orientation with deprecation, so it's backward compatible

@JohnCampionJr
Copy link
Contributor Author

JohnCampionJr commented Oct 3, 2023

@stafyniaksacha Would be glad to but I do not see that option; apparently it is only available to forks on personal accounts. As a workaround, I invited you with write permissions to the repo. That should let you update it :)

@stafyniaksacha stafyniaksacha merged commit abd1523 into shuriken-ui:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants