Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adpot-versions not working #206

Closed
bmarwell opened this issue May 29, 2018 · 5 comments
Closed

adpot-versions not working #206

bmarwell opened this issue May 29, 2018 · 5 comments

Comments

@bmarwell
Copy link
Contributor

Hi,

I have several problems installing adopt and adopt-openj9.
Also, aliases are not set property.

adpot alias

Given

jabba ls-remote "adopt@"  --latest minor
adopt@1.10.0-23
adopt@1.9.0-181
adopt@1.8.172-11

When

jabba install adopt@1.9

Expected

(Installation)

Actual

compatible version found for adopt@1.9

adopt install

Given

jabba install adopt@1.9.0-181

Expected

(Install successfull)

Actual outcome

$ jabba install adopt@1.9.0-181
Downloading adopt@1.9.0-181 (https://github.com/AdoptOpenJDK/openjdk9-releases/releases/download/jdk-9%2B181/OpenJDK9_x64_Linux_jdk-9.181.tar.gz)                                                                                                                              
129195/-1                                                                                                                                                                                                                                                                      
Extracting /tmp/jabba-d-750752711 to $USER/.jabba/jdk/adopt@1.9.0-181                                                                                                                                                                                                  
gzip: invalid header

Same for adopt-openj9@*

alias of adopt-openj9

Given

jabba ls-remote "adopt-openj9@"
adopt-openj9@1.9.0-181
adopt-openj9@1.8.162-12

When

jabba install adopt-openj9@1.9

Expected

(Install)

Actual outcome

No compatible version found for adopt-openj9@1.9
Valid install targets:
@shyiko
Copy link
Owner

shyiko commented May 29, 2018

Hi Ben.

jabba install adopt@1.9.0-181

It looks like @AdoptOpenJDK nuked all openjdk9/openjdk9-openj9 and openjdk10 releases.
See https://twitter.com/adoptopenjdk/status/998522425691332608.

jabba install adopt@1.9 / jabba install adopt-openj9@1.9

The reason these don't work is because jabba is using semver ranges to match available versions. All AdoptOpenJDK builds are marked as "pre-release"s (they have -N suffix) (per https://adoptopenjdk.net notice). jabba install adopt@1.9-0 / jabba install adopt-openj9@1.9-0 should work (1.9-0 is interpreted as ~1.9-0) (when AdoptOpenJDK builds are re-uploaded, that is).

@bmarwell
Copy link
Contributor Author

Thanks a lot!

In conjunction with #115 and more powerful aliases, this will work out just fine.

e.g. oracle@latest, ibm@latest (which is now adopt-openj9), adopt@latest, adpot-openj9@latest etc.

Would also be nice if shipped aliases had a description. Should I open another issue for this?

@shyiko
Copy link
Owner

shyiko commented May 30, 2018

@latest, @ea, etc. aliases are coming in 1.0.0 (which is near completion). There is also jabba inspect <version> to get some rudimentary information about JDK releases before installing them. If you'd like to propose something else - a separate issue(s) would be nice (easier to track).

@shyiko shyiko closed this as completed Jun 1, 2018
@bmarwell
Copy link
Contributor Author

Hi @shyiko,

can you please elaborate "near completion"? :)

@FancyBanana
Copy link

I would like reopen this request since it's been more than a year and there's been no update (literally)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants