Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate "Add Account" dialog on rotation #34

Closed
Bengt opened this issue Apr 1, 2014 · 3 comments
Closed

duplicate "Add Account" dialog on rotation #34

Bengt opened this issue Apr 1, 2014 · 3 comments

Comments

@Bengt
Copy link

Bengt commented Apr 1, 2014

When one opens the "Add Account" dialog box and rotates the phone, the another dialog box pops up right over it. This only happens when there is no account under "Manage Accounts". To add an account it is not enough to just enter all data into the upper dialog box and one has to close all but the last dialog boxes and enter the credentials there. So this can be very annoying and frustrating when gone unnoticed. This is especially critical, because right after installing Conversations, this dialog box is the first thing te user sees. Because there is no account initially, the very first user interaction is broken and in a annoying way. Note that the original dialog box resizes in the right way, so there seems to be no reason to create another one in the first place. There also appears a dialog box, when going to "Manage Accounts" and just rotating the screen.

@rtreffer
Copy link

rtreffer commented Apr 1, 2014

I'd like to suggest an alternative: I've never seen a good dialog on android. Make it a "normal" activity. This will save resolve many headaches. Plus one could add e.g. quick-links for the most common services (clickable icon will insert/replace the at-domain.tld part)

@iNPUTmice
Copy link
Owner

should be fixed in master. can try it myself though right now...

@Bengt
Copy link
Author

Bengt commented Apr 2, 2014

Thanks for the fix, @iNPUTmice! The dialog box does not get duplicated in any situation, anymore for me.

@rtreffer do you still think it would better be an activity? Maybe open another issue for it. I consider this one closed, now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants