Fix #44 Add displayName for configurable #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Thanks! @AndASM btw, what IDE are you using? It seems IDEA 2023.2 doesn't raise any errors related to that. |
|
Thanks for merging that! I got the error on Idea Ultimate 2023.2 and Clion 2023.2, on Windows and Linux. But in all four cases it didn't happen until I installed other plugins. I think it might have been the IdeaVim plugin that triggered it. Very strange. If none of us have missed anything, then it seems like the plugin is carrying 2023.3 beta behaviour backwards into 2023.2. Unfortunately I don't have the mental energy to explore and analyze that right now. Too many languages and systems, not enough brain. |
|
I've managed to reproduce this. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the IntelliJ Platform now requires plugins to list their configurables' names in the plugin xml as an optimization. This is a simple fix for that issue, to prevent users from being pestered with error messages repeatedly while using the IDE.
As noted in the title, this should fix issue #44. The issue effects release version 2023.2, as well as 2023.3 beta (which was noted in the issue title).