[Bug] Expanded notification shade bottom buttons have light background instead of dark

[dazewell]

Describe the issue

When you expand the notification shade, the bottom buttons (VPN monitoring warning; currently active apps button) turn white while they should be black

Steps to reproduce

1. Make sure you're on the light theme
2. Install LSPosed, reboot
3. Install AOSPMods, reboot
4. Open AOSPMods, grant root access, reboot
5. Long tap on the home screen
6. Wallpaper & style
7. Change the system Monet color to a different one than it is right now. Or change the wallpaper while "Wallpaper Colors" is enabled.
8. Expand notification shade.
9. Notice the bottom buttons have white background while the Setting button is okay and has a dark background.

Attaching the same steps before installing AOSPMods and then the same steps after installing AOSPMods.

• Before installing:
  
• After installing:
  

Expected bahavior

The bottom buttons in the notification shade have dark background (similar to the Settings button in the same row).

Your device setup (Please take some time to give correct information here)

• Google Pixel 6
• Android 13 Stable TP1A.220905.004
• September 5, 2022
• 25.2 (25200)
• 
• 
• 1.8.4 (6609) Zygisk
• 
• No setting backup because it happens when NO settings are even enabled.

Logs

LSPosed_2022-09-18T20_08_42.241540.zip

[bzz11g]

Hi there,
I can confirm this bug

Without AOSPmods all working fine

• Google Pixel 6
• Android 13 Stable TP1A.220905.004
• September 5, 2022
• Magisk 25.2 (25200) Zygisk
• LSPosed 1.8.4 (6609) Zygisk
• AOSPmods: canary-135 (Full)

My Magisk and LSposed modules list

AOSPmods settings export (just unzip):
AOSPMODS_settings_export.zip
LSPosed logs:
verbose_LSPosed_2022-09-19T11_57_19.116707.zip
Magisk logs
magisk_log_2022-09-19T11.57.00.log

[EleoXDA]

Can you check whether issue persists when you enable following option:
AOSPMods/Quick Settings/Apply light QS Panel using light theme

[dazewell]

Can you check whether issue persists when you enable following option: AOSPMods/Quick Settings/Apply light QS Panel using light theme

I couldn't reproduce this exact problem, but this flag brings other issues from time to time:

• Notice the clock and date in different colors:
  
• The panel with the buttons at the bottom is weird - rounding is wrong and the color is full black for some reason.
  

[elfametesar]

Can you check whether issue persists when you enable following option: AOSPMods/Quick Settings/Apply light QS Panel using light theme

Applying the light QS makes the UI glitched and switching back to dark after doesn't solve the issue. The UI when applying the light QS wasn't glitched out before, maybe it is a ROM issue but when it wasn't glitched, the issue was gone in light QS but still there in dark QS.

This is after applying the light QS:

This is after restarting SystemUI:

This is after switching back to dark and restarting the SystemUI:

[EleoXDA]

Can you check whether issue persists when you enable following option: AOSPMods/Quick Settings/Apply light QS Panel using light theme

Applying the light QS makes the UI glitched and switching back to dark after doesn't solve the issue. The UI when applying the light QS wasn't glitched out before, maybe it is a ROM issue but when it wasn't glitched, the issue was gone in light QS but still there in dark QS.

This is after applying the light QS:

This is after restarting SystemUI:

This is after switching back to dark and restarting the SystemUI:

which device? ROM? Android version?

[EleoXDA]

Can you check whether issue persists when you enable following option: AOSPMods/Quick Settings/Apply light QS Panel using light theme

I couldn't reproduce this exact problem, but this flag brings other issues from time to time:

• Notice the clock and date in different colors:
  
• The panel with the buttons at the bottom is weird - rounding is wrong and the color is full black for some reason.
  

See mine with and without "Enable dual tone QS panel" option:

Your devices are acting weird. And I am tempted to know why...

[elfametesar]

Poco F3, Evolution X Android 13. For me the light QS isn't a big deal since i don't use it. It's just the bottom buttons that have light theme on dark QS but if you're set on figuring out the other issues, I'll provide you whatever you need.

[EleoXDA]

Poco F3, Evolution X Android 13. For me the light QS isn't a big deal since i don't use it. It's just the bottom buttons that have light theme on dark QS.

Evolution X is not a supported ROM. You already have many tweaks in Evolution X and the source code is changed too much in Evo with respect to AOSP code. It is not possible to support it unless you only support Evo (which already contains modifications)

[elfametesar]

Poco F3, Evolution X Android 13. For me the light QS isn't a big deal since i don't use it. It's just the bottom buttons that have light theme on dark QS.

Evolution X is not a supported ROM. You already have many tweaks in Evolution X and the source code is changed too much in Evo with respect to AOSP code. It is not possible to support it unless you only support Evo (which already contains modifications)

I use this mod mainly for status bar height, and the only problem i seek solution for is the light theme on the bottom buttons like the owner of this thread suggests. Do you have this main issue on your system? Perhaps both the owner of the thread and I are using unsupported ROMs and that's why. If so, I guess I'll have to change ROMs. Although I just realized that the thread owner is using stock and still having this issue.

[EleoXDA]

Poco F3, Evolution X Android 13. For me the light QS isn't a big deal since i don't use it. It's just the bottom buttons that have light theme on dark QS.

Evolution X is not a supported ROM. You already have many tweaks in Evolution X and the source code is changed too much in Evo with respect to AOSP code. It is not possible to support it unless you only support Evo (which already contains modifications)

I use this mod mainly for status bar height, and the only problem i seek solution for is the light theme on the bottom buttons like the owner of this thread suggests. Do you have this main issue on your system? Perhaps both the owner of the thread and I are using unsupported ROMs and that's why. If so, I guess I'll have to change ROMs. Although I just realized that the thread owner is using stock and still having this issue.

Yes, as I replied, he has some issues that we cannot replicate. But your light theme is not what we both can observe. So, maybe if we find what is causing issue on the OP, it can also be applied to you. But there is a strong probability that it will not affect you. So, just that you know.

[bzz11g]

Can you check whether issue persists when you enable following option: AOSPMods/Quick Settings/Apply light QS Panel using light theme

yes, the problem does not occur if you use a light notification theme with light system theme
and no issues with dark theme with switch "Apply light QS Panel using light theme" activated

[dazewell]

Is this an option to move the two settings related to the white BG of the notification shade to the Magisk package leaving the Xposed one without it? Or build a test package without this feature so I could test and confirm it is related or not?

[dazewell]

One another thing to mention, and I've updated the repro steps, is to do ot on the light theme. Please, try again.

I've just tried to disable all modules besides LSPosed and AOSPMods - no luck. It is still happening.

[dazewell]

Well, I've built a version w/o both the light QA and dual tone QS settings (and removed respective controllers) - all is working fine. So, the problem is somewhere in those overlays or hooks. I'm not too familiar with all the stuff, I just wanted to have proof that this is what causes the problems. I hope this can help somehow. I could've attached a resulting zip here if needed.

[bzz11g]

I could've attached a resulting zip here if needed.

Share please, I will also check on my device

[dazewell]

Share please, I will also check on my device

DISCLAIMER: I'm not responsible for any harm this file can do to your device, even though I simply removed several lines of code and built it locally.

AOSPMods_Xposed.zip

Full version cannot be attached due to GH limits.

[elfametesar]

Share please, I will also check on my device

DISCLAIMER: I'm not responsible for any harm this file can do to your device, even though I simply removed several lines of code and built it locally.

AOSPMods_Xposed.zip

Full version cannot be attached due to GH limits.

This fixes the issue, can you do the full version too?

[dazewell]

This fixes the issue, can you do the full version too?

I can, but cannot attach it to GitHub. Ping me in the telegram support group, I can put it there I think.

[EleoXDA]

Well, I've built a version w/o both the light QA and dual tone QS settings (and removed respective controllers) - all is working fine. So, the problem is somewhere in those overlays or hooks. I'm not too familiar with all the stuff, I just wanted to have proof that this is what causes the problems. I hope this can help somehow. I could've attached a resulting zip here if needed.

The only problem is with the standard light theme on my device. The light light theme is working fine. The dark theme works fine. But the standard light theme (with black qs bg and white notification bg) is faulty.

It was my advice to Siavash to remove the possibility of a standard light theme, because it looks very odd. Then the themes work fine and colors work ok as far as I have tested. The white and black clock color gets reset back to normal after a systemUI restart. And that black bar in bottom is only because of "standard theme". If you use repainter with amoled black bg or pitch black theme in AOSPMods that bar is invisible

[EleoXDA]

Is this duplicate of this bugreport?
#336

[dazewell]

Is this duplicate of this bugreport? #336

It is, yes, but for some reason, @siavash79 has asked not to close it but just create a new one. It is fine I think if we close it and just keep a link to it.

[EleoXDA]

No problem, let's let Siavash read it

[siavash79]

Expect the fix in canary 139