Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Config creation interface if no config is provided #34

Closed
sibalzer opened this issue May 27, 2021 · 10 comments
Closed

Config creation interface if no config is provided #34

sibalzer opened this issue May 27, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@sibalzer
Copy link
Owner

sibalzer commented May 27, 2021

A guided config setup via cli or even better gui, would great for inexperienced users.

Features

  • generating config file
  • easy to use & understand
  • step by step
  • integrated check (no validation script needed afterwards)
@sibalzer sibalzer added enhancement New feature or request help wanted Extra attention is needed labels May 27, 2021
@paulypeter
Copy link
Collaborator

Can you specify your requirements?

@sibalzer
Copy link
Owner Author

Added. Btw your fork needs to reset hard to sibalzer/master. I had to rebase because of an information leak. Sorry for that.

@paulypeter
Copy link
Collaborator

I will implement that.

Alright, will do before starting this issue. You can assign me to it.

@paulypeter
Copy link
Collaborator

paulypeter commented May 28, 2021

Some notes for myself

  • implement GUI form
  • implement CLI (mainly as fallback when GUI isn't working, e. g. on a headless system)
  • (?) add language selection

@paulypeter
Copy link
Collaborator

paulypeter commented May 29, 2021

  • add validation

@paulypeter
Copy link
Collaborator

paulypeter commented May 29, 2021

@sibalzer Do you want the [ADVANCED] settings included? Otherwise, tested defaults could be fine.

Also, checking for a valid email is hard via regex, so so far I only check whether at least something was put into the form.

@sibalzer
Copy link
Owner Author

I dont think this necessary, it should be as simple as possible (but if you have time, feel free). As email regex we could use the RFC 5322 compatible one from here: emailregex, but this seems to be a science in itself. http://emailregex.com/

@sibalzer sibalzer added this to the v3.0.0. milestone May 29, 2021
@paulypeter
Copy link
Collaborator

I thought about including that one, I didn't know whether you'd want that. I will include it.

@paulypeter
Copy link
Collaborator

paulypeter commented May 30, 2021

Update: Now every notifier input is checked against a regex

@paulypeter
Copy link
Collaborator

closed with #83

@sibalzer sibalzer closed this as completed Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants