-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to clone and run the app #2
Comments
could you send a PR, removing this fontFamily victory-native-demo-crna/App.js Line 38 in 2251e1f
|
I took a look at the native-component-list app as mentioned by @dikaiosune in expo/create-react-native-app#121
Why is react-native version a url? What version number should we actually use here? |
@nikhilag feel free send a PR fixing this |
@sibelius I really want to fix this but I am trying to figure out how. As of now, no matter what version i use in package.json, victory-native doesn't work with crna. I keep getting the error that I posted above. I haven't tried the package.json used in native-component-list yet but it doesn't seem the correct approach. Why are they using a custom url for react-native and why are they using an old version of victory-native? |
I think they are using an old version of react-native-svg, so this is probably breaking the new version of victory-native |
@nikhilag the Expo client usually has a ~1 week delay from a stable React Native release, I expect RN 0.43 support will be released early next week. By default Expo projects use a fork of RN so that we can ship important bugfixes early if need be, but both "vanilla" RN from npm and the Expo fork tarball should work just fine. I suspect the old version of victory-native is because that's the version that's compatible with the react-native-svg we ship in the client app, but I could be wrong. Maybe @brentvatne can fill in with details there? |
Is support for 0.43 coming soon? |
hello! I added victory-native to an expo examples repo here: https://github.com/expo/examples/tree/master/with-victory-native |
looks good tks |
I tried to run the app after cloning the repository but I got the following error:-
"console.error: fontFamily 'Menlo' is not a system font and has not been loaded through Exponent.Font.loadAsync."
The text was updated successfully, but these errors were encountered: