Split loading and parsing in separate methods

[lommes]

Hi,

I played around and really like your package. It would be a nice addition if loading and parsing of the gpx data would be split in different methods, so it can be parsed from database entries.

Regards
Timo

[Sibyx]

Hi,
thanks! So if I get it right you want to split phpGPX::load() method into multiple methods which allows loading from other sources? For example:

• loadFromFile()
• loadFromString()

Regards
Jakub

[lommes]

Or, which might even be easier, keep the load method with the file as parameter, read files content and directly pass it to a second method which does the stuff from here to here. So load will stay the loadFromFile and the new method can be used directly to load from string.

[Sibyx]

Yop, also quite a good idea, but there is one more thing to resolve: we have to somehow provide a backward compatibility with previous. I am not very sure if its a good idea to change a parameter in the phpGPX::load function.

[lommes]

This will not break anything since the path is already the only parameter. I will create a pull request to clarify later.

[Sibyx]

Ah, yes I see, we just need implement extra function for loading data from string which will be used in phpGPX::load(). I hope I get it now :D Looking forward to your pull request!

[Sibyx]

Resolved & implemented with #9 Thank you 👍