Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuboCop 0.49.1; rake task; linting #64

Merged
merged 5 commits into from
Jul 2, 2017
Merged

RuboCop 0.49.1; rake task; linting #64

merged 5 commits into from
Jul 2, 2017

Conversation

olleolleolle
Copy link
Collaborator

@olleolleolle olleolleolle commented Jun 30, 2017 •
edited
Loading

This PR introduces responds_to_missing? RuboCop warning fixes.

  • default Rake task: include RuboCop
  • RuboCop: update TODO file
  • RuboCop: display name and URL for style warnings, to make them more actionable
  • Gemfile: pin to exact version of RuboCop
  • Appveyor: Styleguide rule on crlf in Git.

@olleolleolle olleolleolle requested a review from ku1ik June 30, 2017 10:50
@olleolleolle olleolleolle self-assigned this Jun 30, 2017
@olleolleolle
Copy link
Collaborator Author

(I had made a typo in the RuboCop configuration file which made it not exclude the vendor/**/* pattern. Now it ought to run to completion.)

@olleolleolle
Copy link
Collaborator Author

@sickill Ha!

@olleolleolle olleolleolle merged commit 1a61b33 into master Jul 2, 2017
@olleolleolle olleolleolle deleted the fix/rubocop-0-49-1 branch July 2, 2017 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ku1ik ku1ik Awaiting requested review from ku1ik

Assignees

@olleolleolle olleolleolle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@olleolleolle