New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate kwargs from SessionFactory constructor to create_engine #76
Comments
I've actually been thinking of removing the custom arguments that |
I like your proposed change. It would make more flexible but maybe backward compatibility may be compromised. Any use of it with positional arguments may break the API. Let me see if our colleagues have some thoughts about it. @igorcandeia @nicoddemus @kfasolin @igortg |
I don't see much problem in breaking backward compatibility here: if you are following semantic versioning then there are no backward compatibility guarantees for |
I agree, since the definition on SQLAlchemy already is |
Cool. I've requested an update to #78 . |
Just merged #78 . I'll try to make another release in the next 2-3 days. |
Solved on #78 |
Just pushed |
Kwargs is created empty for setting up the sqlalchemy create_engine this makes impossible to someone add specific settings for creating the engine.
An alternative would be to propagate from session factory kwargs. By doing that, it should allow any user to set all possible parameters like in:
https://docs.sqlalchemy.org/en/latest/core/engines.html#engine-creation-api
Issue reference:
tornado-sqlalchemy/tornado_sqlalchemy/__init__.py
Line 135 in 6a3f82a
The text was updated successfully, but these errors were encountered: