Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race conditions: PR can be compared to outdated 'master' depending on Travis build run time #159

Open
erichdev opened this issue Oct 11, 2017 · 1 comment

Comments

@erichdev
Copy link

Do you want to request a feature or report a bug?
Bug

What is the current behavior? If the current behavior is a bug, please provide the steps to reproduce.
Travis job run times can be unpredictable and lead to outdated bundlesize comparisons. For example, if a PR is merged, triggering a Travis build, and then a new PR is submitted, kicking off another Travis build, the second Travis build may complete before the first one, resulting in the PR size being compared to the old master values from before the merge commit.

See #155 (comment) for reference

What is the expected behavior?
bundlesize should compare the PR size to the latest version of master.

If this is a feature request, what is motivation or use case for changing the behavior?

Please mention other relevant information.

  • node version
  • npm version
  • Operating system
  • bundlesize version
  • CI you are using
@siddharthkp
Copy link
Owner

Thanks for taking the time to report this!

I don't have a solution to this right now, but will circle back to it sometime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants