Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update axios dependency due to security vulnerability #369

Closed
sceee opened this issue Jan 5, 2021 · 8 comments
Closed

Update axios dependency due to security vulnerability #369

sceee opened this issue Jan 5, 2021 · 8 comments

Comments

@sceee
Copy link

sceee commented Jan 5, 2021

Do you want to request a feature or report a bug?
Report an outdated, vulnerable dependency.

What is the current behavior?
axios is not updated to a fixed version for the following advisory ( https://www.npmjs.com/advisories/1594 ) as bundlesize depends on axios ^0.19.0 which prevents npm from updating the dependency to 0.21.1 or higher.

If the current behavior is a bug, please provide the steps to reproduce.
N/A

What is the expected behavior?
axios dependency is updated to >=0.21.1 to depend on a version that fixes the following advisory: https://www.npmjs.com/advisories/1594

If this is a feature request, what is motivation or use case for changing the behavior?
N/A

Please mention other relevant information.
N/A

@sceee
Copy link
Author

sceee commented Jan 5, 2021

Additional note, there are two paths bundlesize pulls in axios, one being direct and one being transient:

  • bundlesize > axios
  • bundlesize > github-build > axios

@abbyblachman
Copy link

+1

4 similar comments
@emilyyount
Copy link

+1

@dcosta-ptc
Copy link

+1

@bartek-kisielewicz
Copy link

+1

@RichardWright
Copy link

+1

@siddharthkp
Copy link
Owner

Fixed in bundlesize@0.18.1

@siddharthkp
Copy link
Owner

Also fixed in https://github.com/siddharthkp/bundlesize2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants