Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long bundle path causes truncation of text in GitHub UI #72

Closed
jazlalli opened this issue Jul 20, 2017 · 7 comments
Closed

Long bundle path causes truncation of text in GitHub UI #72

jazlalli opened this issue Jul 20, 2017 · 7 comments

Comments

@jazlalli
Copy link

As you can see from the screenshot below

screen shot 2017-07-19 at 18 11 50

Perhaps only showing that last directory and the filename, prefixed with ... would be better, as the most useful information follows that. The full path could be shown when hovering over the summary.

If you have a solution in mind, I'd be happy to try and make the change for you. I'm guessing doing some path manipulation here would do it?

@siddharthkp
Copy link
Owner

siddharthkp commented Jul 20, 2017

Sounds good!

@palashmon
Copy link
Collaborator

I am not working on this case yet, but I just wanted to discuss some test case scenarios and gets inputs from other also. This might be helpful for any other contributor who wants to work on it in future.

  • Best case scenario

    When file name is short like:

    ./dist.js
    

    In this case no truncation of text is needed.

  • 2nd scenario

    When file path is long like:

    ./lighthouse-extension/dist/scripts/lighthouse-background.js
    

    In this case, I think we can truncate it to like ~/lighthouse-background.js.
    What do you think?

  • 3rd scenario

    When file name is long (more than 35 chars) like:

    ./lighthouse-background-long-filename.js
    

    In this case, I think we can truncate it to something like ~/light...name.js.
    What do you think?

What other test case scenarios we have?

@siddharthkp
Copy link
Owner

I like all of those solutions!

I'd also like to add the case of multiple files in possibly different folders.

@siddharthkp
Copy link
Owner

Another thing I'll throw into the mix is: should we do this in the CLI or on the store/details page.

Doing it in the CLI is a more effective use of URL length, but doing on the details page gives us the flexibility of deploying whenever we want even with breaking changes.

@siddharthkp
Copy link
Owner

Whoops, we should this conversation to #81

@vs1682
Copy link

vs1682 commented Aug 27, 2017

You mean showing the path with it's parent directory, right?
Like
~/parent1/file1.js
~/parent2/file2.js

@siddharthkp
Copy link
Owner

@vs1682 yep.

moved to #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants