db/cluster: stable cluster start up #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Nov 6, 2018
db/cluster/cluster.go
Outdated
| if err == nil { | ||
| break | ||
| } | ||
| log.Println("wait pd cluster...") |
siddontang
reviewed
Nov 6, 2018
db/cluster/cluster.go
Outdated
| @@ -138,6 +138,17 @@ func (cluster *Cluster) start(ctx context.Context, node string, inSetUp bool) er | |||
| return fmt.Errorf("fail to start pd on node %s", node) | |||
| } | |||
|
|
|||
| // Before starting TiKV, we should ensure PD cluster is ready. | |||
| for { | |||
There was a problem hiding this comment.
if there is a bug for PD, we may wait forever.
tabokie
pushed a commit
to tabokie/chaos
that referenced
this pull request
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It waits pd before starting tikv to avoid tikv start up failure. Also it fixs a bug that cause
start-stop-daemonfailure.