Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis pool size is not correct by default #399

Open
beltrachi opened this issue Aug 10, 2022 · 0 comments
Open

Redis pool size is not correct by default #399

beltrachi opened this issue Aug 10, 2022 · 0 comments

Comments

@beltrachi
Copy link

Hi,

checking the README, it states that there is nothing to do if you are not configuring your own redis pool on Sidekiq.

If you're configuring your own Redis connection pool, you need to make sure the size is adequate to be inclusive of both Sidekiq's own connection pool and Rufus Scheduler's.

Sidekiq by default has a concurrency of 10, so it creates a pool of 10 + 5 = 15 which is not enough, right? It should be 5 + 5 + Rufus::Scheduler::MAX_WORK_THREADS to make sure no thread is blocked by the redis pool.

Sidekiq-scheduler does not change Sidekiq Redis connection pool size in any way to make room for Rufus threads, is it? At least I could not find a place where this happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant