Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend Sidekiq::Job instead of Sidekiq::Worker #456

Closed
jrmhaig opened this issue Nov 27, 2023 · 1 comment · Fixed by #457
Closed

Recommend Sidekiq::Job instead of Sidekiq::Worker #456

jrmhaig opened this issue Nov 27, 2023 · 1 comment · Fixed by #457

Comments

@jrmhaig
Copy link
Contributor

jrmhaig commented Nov 27, 2023

Sidekiq 7 has deprecated Sidekiq::Worker in favour of Sidekiq::Job and I believe that Sidekiq::Job was first introduced as an alias in 6.3. The documentation for sidekiq-scheduler indicates that Sidekiq::Worker should be used. I appreciate that sidekiq-scheduler needs to support earlier version of sidekiq so perhaps there could be a note added to indicate that Sidekiq::Job is recommended for more recent version.
@marcelolx
Copy link
Member

Yeah, I agree with you. Feel free to send a PR with the changes if you are willing to; Otherwise, I will look into it when I have some free time

@jrmhaig jrmhaig mentioned this issue Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add note about Sidekiq::Job jrmhaig/sidekiq-scheduler
2 participants
@jrmhaig @marcelolx