Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SidekiqScheduler::Manager enormous inspect output #462

Open
eapache-opslevel opened this issue Mar 4, 2024 · 2 comments
Open

SidekiqScheduler::Manager enormous inspect output #462

eapache-opslevel opened this issue Mar 4, 2024 · 2 comments

Comments

@eapache-opslevel
Copy link

Trying to inspect an instance of SidekiqScheduler::Manager produces around 5k lines of output on our system because it holds references to a bunch of other complex objects and eventually starts printing large chunks of internal sidekiq and rails objects.

This is doubly annoying because with debug-logging enabled on sidekiq, the SidekiqScheduler::Manager instance is inspected/logged at sidekiq startup.

It's easy enough to monkey-patch with something like:

module SidekiqScheduler
  class Manager
    def inspect
      "SidekiqScheduler::Manager"
    end
  end
end

But there should probably be some debugging information included, and I don't know what values are worth logging here.

@marcelolx
Copy link
Member

@eapache-opslevel could you provide this output? as an attached file and not a comment please 😄

@eapache-opslevel
Copy link
Author

eapache-opslevel commented May 16, 2024

I am not able to share this output, as the resulting dump of ruby objects includes a great deal of sensitive information about our code base, including e.g. our redis password. It is 2MB of text, so it is too large for me to manually redact all the sensitive information.

You should be able to reproduce for yourself by running bundle exec sidekiq -v on a sidekiq setup with sidekiq-scheduler. Any sidekiq version after 7.0.7 (sidekiq/sidekiq#5822 is required) should print the config object when started with -v and will thus trigger the inspect of the scheduler-manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants