Replies: 1 comment
-
I think the best approach here would be to open a PR with a proposed improvement so we can talk about actual implementation details and tradeoffs. No promises but that's more grounded than a high-level discussion. WDYT? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I think
Sidekiq::TransactionAwareClient
is great. At Gusto, we've leaned intoSidekiq.transactional_push!
heavily but would love to see some improvements.TransactionAwareClient
does not supportpush_bulk
, understandably. However, it would be nice to be able to actually supportpush_bulk
but perhaps have limits on the number of jobs in memory, and erring if that limit is reached. And/Or, allow an option to be set onTransactionAwareClient
that raises an error whenpush_bulk
is called whileAfterCommitEverywhere.in_transaction?
istrue
.Currently we're using the isolator gem to catch job enqueueing while in a DB transaction, but it would be nice to drop it completely if this detection was baked into
TransactionAwareClient
.Beta Was this translation helpful? Give feedback.
All reactions