Skip to content

Commit

Permalink
chore: move cli formatters and version modules to machinery
Browse files Browse the repository at this point in the history
To be used in the `go-talos-support` module without importing the whole
Talos repo.

Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
  • Loading branch information
Unix4ever committed Mar 7, 2024
1 parent 8152a6d commit 3c8f51d
Show file tree
Hide file tree
Showing 43 changed files with 67 additions and 58 deletions.
2 changes: 1 addition & 1 deletion cmd/installer/cmd/installer/install.go
Expand Up @@ -15,7 +15,7 @@ import (
"github.com/siderolabs/talos/cmd/installer/pkg/install"
"github.com/siderolabs/talos/internal/app/machined/pkg/runtime/v1alpha1/platform"
"github.com/siderolabs/talos/pkg/machinery/config/configloader"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// installCmd represents the installation command.
Expand Down
2 changes: 1 addition & 1 deletion cmd/installer/pkg/install/install.go
Expand Up @@ -25,7 +25,7 @@ import (
"github.com/siderolabs/talos/internal/pkg/mount"
"github.com/siderolabs/talos/pkg/machinery/constants"
"github.com/siderolabs/talos/pkg/machinery/kernel"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// Options represents the set of options available for an install.
Expand Down
2 changes: 1 addition & 1 deletion cmd/installer/pkg/install/preflight.go
Expand Up @@ -22,7 +22,7 @@ import (
"github.com/siderolabs/talos/pkg/machinery/constants"
"github.com/siderolabs/talos/pkg/machinery/resources/k8s"
"github.com/siderolabs/talos/pkg/machinery/role"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// PreflightChecks runs the preflight checks.
Expand Down
2 changes: 1 addition & 1 deletion cmd/talosctl/cmd/mgmt/cluster/create.go
Expand Up @@ -45,10 +45,10 @@ import (
"github.com/siderolabs/talos/pkg/machinery/config/types/v1alpha1"
"github.com/siderolabs/talos/pkg/machinery/constants"
"github.com/siderolabs/talos/pkg/machinery/nethelpers"
"github.com/siderolabs/talos/pkg/machinery/version"
"github.com/siderolabs/talos/pkg/provision"
"github.com/siderolabs/talos/pkg/provision/access"
"github.com/siderolabs/talos/pkg/provision/providers"
"github.com/siderolabs/talos/pkg/version"
)

const (
Expand Down
3 changes: 2 additions & 1 deletion cmd/talosctl/cmd/talos/inspect.go
Expand Up @@ -14,6 +14,7 @@ import (
"github.com/siderolabs/talos/cmd/talosctl/pkg/talos/helpers"
"github.com/siderolabs/talos/pkg/cli"
"github.com/siderolabs/talos/pkg/machinery/client"
"github.com/siderolabs/talos/pkg/machinery/formatters"
)

// inspectCmd represents the inspect command.
Expand Down Expand Up @@ -54,7 +55,7 @@ to render the graph:
cli.Warning("%s", err)
}

return cli.RenderGraph(ctx, c, resp, os.Stdout, inspectDependenciesCmdFlags.withResources)
return formatters.RenderGraph(ctx, c, resp, os.Stdout, inspectDependenciesCmdFlags.withResources)
})
},
}
Expand Down
3 changes: 2 additions & 1 deletion cmd/talosctl/cmd/talos/mounts.go
Expand Up @@ -15,6 +15,7 @@ import (

"github.com/siderolabs/talos/pkg/cli"
"github.com/siderolabs/talos/pkg/machinery/client"
"github.com/siderolabs/talos/pkg/machinery/formatters"
)

// mountsCmd represents the mounts command.
Expand All @@ -37,7 +38,7 @@ var mountsCmd = &cobra.Command{
cli.Warning("%s", err)
}

return cli.RenderMounts(resp, os.Stdout, &remotePeer)
return formatters.RenderMounts(resp, os.Stdout, &remotePeer)
})
},
}
Expand Down
4 changes: 2 additions & 2 deletions cmd/talosctl/cmd/talos/root.go
Expand Up @@ -20,12 +20,12 @@ import (
"google.golang.org/grpc/peer"

"github.com/siderolabs/talos/cmd/talosctl/pkg/talos/global"
"github.com/siderolabs/talos/pkg/cli"
_ "github.com/siderolabs/talos/pkg/grpc/codec" // register codec
"github.com/siderolabs/talos/pkg/machinery/api/common"
machineapi "github.com/siderolabs/talos/pkg/machinery/api/machine"
"github.com/siderolabs/talos/pkg/machinery/client"
"github.com/siderolabs/talos/pkg/machinery/constants"
"github.com/siderolabs/talos/pkg/machinery/formatters"
)

var kubernetes bool
Expand Down Expand Up @@ -165,7 +165,7 @@ func getServiceFromNode() []string {

for _, msg := range resp.Messages {
for _, s := range msg.Services {
svc := cli.ServiceInfoWrapper{ServiceInfo: s}
svc := formatters.ServiceInfoWrapper{ServiceInfo: s}
svcIDs = append(svcIDs, svc.Id)
}
}
Expand Down
5 changes: 3 additions & 2 deletions cmd/talosctl/cmd/talos/service.go
Expand Up @@ -16,6 +16,7 @@ import (

"github.com/siderolabs/talos/pkg/cli"
"github.com/siderolabs/talos/pkg/machinery/client"
"github.com/siderolabs/talos/pkg/machinery/formatters"
)

// serviceCmd represents the service command.
Expand Down Expand Up @@ -89,7 +90,7 @@ func serviceList(ctx context.Context, c *client.Client) error {

for _, msg := range resp.Messages {
for _, s := range msg.Services {
svc := cli.ServiceInfoWrapper{ServiceInfo: s}
svc := formatters.ServiceInfoWrapper{ServiceInfo: s}

node := defaultNode

Expand Down Expand Up @@ -122,7 +123,7 @@ func serviceInfo(ctx context.Context, c *client.Client, id string) error {
return fmt.Errorf("service %q is not registered on any nodes", id)
}

return cli.RenderServicesInfo(services, os.Stdout, defaultNode, true)
return formatters.RenderServicesInfo(services, os.Stdout, defaultNode, true)
}

func serviceStart(ctx context.Context, c *client.Client, id string) error {
Expand Down
2 changes: 1 addition & 1 deletion cmd/talosctl/cmd/talos/upgrade.go
Expand Up @@ -26,7 +26,7 @@ import (
"github.com/siderolabs/talos/pkg/images"
"github.com/siderolabs/talos/pkg/machinery/api/machine"
"github.com/siderolabs/talos/pkg/machinery/client"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

var upgradeCmdFlags struct {
Expand Down
2 changes: 1 addition & 1 deletion cmd/talosctl/cmd/talos/version.go
Expand Up @@ -16,7 +16,7 @@ import (

"github.com/siderolabs/talos/pkg/cli"
"github.com/siderolabs/talos/pkg/machinery/client"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// versionCmdFlags represents the `talosctl version` command's flags.
Expand Down
2 changes: 1 addition & 1 deletion cmd/talosctl/pkg/mgmt/helpers/image.go
Expand Up @@ -8,7 +8,7 @@ import (
"fmt"
"os"

"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// DefaultImage appends default image version.
Expand Down
2 changes: 1 addition & 1 deletion cmd/talosctl/pkg/talos/helpers/checks.go
Expand Up @@ -16,7 +16,7 @@ import (

"github.com/siderolabs/talos/pkg/machinery/api/common"
"github.com/siderolabs/talos/pkg/machinery/client"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// FailIfMultiNodes checks if ctx contains multi-node request metadata.
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Expand Up @@ -56,7 +56,6 @@ require (
github.com/docker/go-connections v0.5.0
github.com/dustin/go-humanize v1.0.1
github.com/ecks/uefi v0.0.0-20221116212947-caef65d070eb
github.com/emicklei/dot v1.6.1
github.com/fatih/color v1.16.0
github.com/foxboron/go-uefi v0.0.0-20240128152106-48be911532c2
github.com/freddierice/go-losetup/v2 v2.0.1
Expand Down Expand Up @@ -215,6 +214,7 @@ require (
github.com/docker/docker-credential-helpers v0.7.0 // indirect
github.com/docker/go-events v0.0.0-20190806004212-e31b211e4f1c // indirect
github.com/docker/go-units v0.5.0 // indirect
github.com/emicklei/dot v1.6.1 // indirect
github.com/emicklei/go-restful/v3 v3.11.0 // indirect
github.com/evanphx/json-patch v5.9.0+incompatible // indirect
github.com/exponent-io/jsonpath v0.0.0-20151013193312-d6023ce2651d // indirect
Expand Down
2 changes: 1 addition & 1 deletion internal/app/apid/pkg/backend/apid_test.go
Expand Up @@ -32,7 +32,7 @@ import (
"github.com/siderolabs/talos/pkg/machinery/config"
"github.com/siderolabs/talos/pkg/machinery/proto"
"github.com/siderolabs/talos/pkg/machinery/role"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

type APIDSuite struct {
Expand Down
2 changes: 1 addition & 1 deletion internal/app/init/main.go
Expand Up @@ -29,7 +29,7 @@ import (
"github.com/siderolabs/talos/internal/pkg/secureboot/tpm2"
"github.com/siderolabs/talos/pkg/machinery/constants"
"github.com/siderolabs/talos/pkg/machinery/extensions"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

func init() {
Expand Down
Expand Up @@ -87,7 +87,7 @@ import (
"github.com/siderolabs/talos/pkg/machinery/resources/network"
timeresource "github.com/siderolabs/talos/pkg/machinery/resources/time"
"github.com/siderolabs/talos/pkg/machinery/role"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// MinimumEtcdUpgradeLeaseLockSeconds indicates the minimum number of seconds for which we open a lease lock for upgrading Etcd nodes.
Expand Down
Expand Up @@ -30,7 +30,7 @@ import (
"github.com/siderolabs/talos/pkg/machinery/resources/kubespan"
"github.com/siderolabs/talos/pkg/machinery/resources/network"
"github.com/siderolabs/talos/pkg/machinery/resources/runtime"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

const defaultDiscoveryTTL = 30 * time.Minute
Expand Down
Expand Up @@ -25,7 +25,7 @@ import (
"github.com/siderolabs/talos/pkg/machinery/resources/k8s"
"github.com/siderolabs/talos/pkg/machinery/resources/kubespan"
"github.com/siderolabs/talos/pkg/machinery/resources/network"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// LocalAffiliateController builds Affiliate resource for the local node.
Expand Down
Expand Up @@ -23,7 +23,7 @@ import (
"github.com/siderolabs/talos/pkg/machinery/resources/k8s"
"github.com/siderolabs/talos/pkg/machinery/resources/kubespan"
"github.com/siderolabs/talos/pkg/machinery/resources/network"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

type LocalAffiliateSuite struct {
Expand Down
Expand Up @@ -38,7 +38,7 @@ import (
"github.com/siderolabs/talos/pkg/machinery/resources/network"
"github.com/siderolabs/talos/pkg/machinery/resources/runtime"
"github.com/siderolabs/talos/pkg/machinery/resources/siderolink"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// ManagerController interacts with SideroLink API and brings up the SideroLink Wireguard interface.
Expand Down
Expand Up @@ -11,7 +11,7 @@ import (
"path/filepath"

"github.com/siderolabs/talos/pkg/machinery/constants"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// Config represents a grub configuration file (grub.cfg).
Expand Down
Expand Up @@ -19,7 +19,7 @@ import (
"github.com/stretchr/testify/require"

"github.com/siderolabs/talos/internal/app/machined/pkg/runtime/v1alpha1/bootloader/grub"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

var (
Expand Down
Expand Up @@ -78,8 +78,8 @@ import (
"github.com/siderolabs/talos/pkg/machinery/resources/k8s"
resourceruntime "github.com/siderolabs/talos/pkg/machinery/resources/runtime"
resourcev1alpha1 "github.com/siderolabs/talos/pkg/machinery/resources/v1alpha1"
"github.com/siderolabs/talos/pkg/machinery/version"
"github.com/siderolabs/talos/pkg/minimal"
"github.com/siderolabs/talos/pkg/version"
)

// WaitForUSB represents the WaitForUSB task.
Expand Down
2 changes: 1 addition & 1 deletion internal/app/maintenance/server.go
Expand Up @@ -35,7 +35,7 @@ import (
v1alpha1machine "github.com/siderolabs/talos/pkg/machinery/config/machine"
"github.com/siderolabs/talos/pkg/machinery/constants"
"github.com/siderolabs/talos/pkg/machinery/role"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// Server implements [machine.MachineServiceServer], network.NetworkService, and [storage.StorageServiceServer].
Expand Down
2 changes: 1 addition & 1 deletion internal/integration/cli/version.go
Expand Up @@ -10,7 +10,7 @@ import (
"regexp"

"github.com/siderolabs/talos/internal/integration/base"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// VersionSuite verifies version command.
Expand Down
2 changes: 1 addition & 1 deletion internal/integration/integration_test.go
Expand Up @@ -25,9 +25,9 @@ import (
"github.com/siderolabs/talos/pkg/images"
clientconfig "github.com/siderolabs/talos/pkg/machinery/client/config"
"github.com/siderolabs/talos/pkg/machinery/constants"
"github.com/siderolabs/talos/pkg/machinery/version"
"github.com/siderolabs/talos/pkg/provision"
"github.com/siderolabs/talos/pkg/provision/providers"
"github.com/siderolabs/talos/pkg/version"
)

// Accumulated list of all the suites to run.
Expand Down
2 changes: 1 addition & 1 deletion internal/integration/k8s/tink.go
Expand Up @@ -39,7 +39,7 @@ import (
"github.com/siderolabs/talos/pkg/machinery/config/generate"
"github.com/siderolabs/talos/pkg/machinery/config/machine"
"github.com/siderolabs/talos/pkg/machinery/constants"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// TinkSuite verifies Talos-in-Kubernetes.
Expand Down
2 changes: 1 addition & 1 deletion internal/integration/provision/provision.go
Expand Up @@ -44,10 +44,10 @@ import (
"github.com/siderolabs/talos/pkg/machinery/config/types/v1alpha1"
"github.com/siderolabs/talos/pkg/machinery/constants"
"github.com/siderolabs/talos/pkg/machinery/nethelpers"
"github.com/siderolabs/talos/pkg/machinery/version"
"github.com/siderolabs/talos/pkg/provision"
"github.com/siderolabs/talos/pkg/provision/access"
"github.com/siderolabs/talos/pkg/provision/providers/qemu"
"github.com/siderolabs/talos/pkg/version"
)

var allSuites []suite.TestingSuite
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/extensions/extensions_test.go
Expand Up @@ -13,7 +13,7 @@ import (
"github.com/stretchr/testify/require"

"github.com/siderolabs/talos/internal/pkg/extensions"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

func TestLoadValidate(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/extensions/validate.go
Expand Up @@ -14,7 +14,7 @@ import (
"github.com/blang/semver/v4"

"github.com/siderolabs/talos/pkg/machinery/extensions"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// Validate the extension: compatibility, contents, etc.
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/secureboot/uki/generate.go
Expand Up @@ -17,8 +17,8 @@ import (
"github.com/siderolabs/talos/internal/pkg/secureboot"
"github.com/siderolabs/talos/internal/pkg/secureboot/measure"
"github.com/siderolabs/talos/pkg/machinery/constants"
"github.com/siderolabs/talos/pkg/machinery/version"
"github.com/siderolabs/talos/pkg/splash"
"github.com/siderolabs/talos/pkg/version"
)

func (builder *Builder) generateOSRel() error {
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/tui/installer/installer.go
Expand Up @@ -18,7 +18,7 @@ import (
"github.com/siderolabs/talos/internal/pkg/tui/components"
machineapi "github.com/siderolabs/talos/pkg/machinery/api/machine"
clientconfig "github.com/siderolabs/talos/pkg/machinery/client/config"
"github.com/siderolabs/talos/pkg/version"
"github.com/siderolabs/talos/pkg/machinery/version"
)

// NewPage creates a new installer page.
Expand Down
2 changes: 1 addition & 1 deletion pkg/cluster/sonobuoy/product.go
Expand Up @@ -4,7 +4,7 @@

package sonobuoy

import "github.com/siderolabs/talos/pkg/version"
import "github.com/siderolabs/talos/pkg/machinery/version"

type product struct {
Vendor string `yaml:"vendor"`
Expand Down

0 comments on commit 3c8f51d

Please sign in to comment.