Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talosctl: Make the binary available in Brew (osx) #2148

Closed
patatman opened this issue May 27, 2020 · 11 comments
Closed

Talosctl: Make the binary available in Brew (osx) #2148

patatman opened this issue May 27, 2020 · 11 comments

Comments

@patatman
Copy link
Contributor

Feature Request

Make the talosctl available in homebrew on OSX.

Description

It would be very easy to install for Mac users, so I recommend also adding it over there.
Users can then use a one-liner to install the CTL.

brew install talosctl

Information on homebrew: homepage
For adding a Tap: Create a tap

@rsmitty
Copy link
Member

rsmitty commented May 27, 2020

Hey @patatman, we've started work on this previously here. I just haven't kept up with it well since updating it is currently a manual process. Need to get some automation around it before I want to add it to our docs. We'll keep this issue open and use it as a tracker for getting this done!

@patatman
Copy link
Contributor Author

So maybe we could do this trough the Drone pipeline?
Maybe introduce an extra step in the notify pipeline section, since this is triggered when there is a new release.
I don't see a git plugin to clone and push a repo, so I guess we would have to do a exec?

Or am I missing something?

@andrewrynhard
Copy link
Member

Isn't there a way to add the to brew in some official way?

@rsmitty
Copy link
Member

rsmitty commented May 27, 2020

@patatman I think you're idea is more/less what I had in mind too. An extra drone step that creates a PR with updated version and SHA to the homebrew repo when a release happens.

@andrewrynhard I don't think we want to go down the official route because they won't accept just plopping down a binary. They want you to compile from source to be accepted in the main repo. https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae

@patatman
Copy link
Contributor Author

@rsmitty I created a fork: https://github.com/patatman/homebrew-talos
Just tested on Osx Catalina, but it seems OSX has some additional hardening done. It can't be executed when installed trough Brew.

It says the binary is from a unidentified developer.

Similar topic: hashicorp/terraform#23033

But other than this, it has the new version (0.5.0) of talosctl running. Untill we have a working automatic way, we might be able to PR this into the repo and get it working for now.

@rsmitty
Copy link
Member

rsmitty commented May 28, 2020

@patatman Yep, I think I ran into that the last time I updated things. I'm not sure there's a great way around it, but we'll have to do some research. If you want to PR your fork changes to get 0.5 released, that'd be awesome!

@AlekSi
Copy link
Contributor

AlekSi commented Mar 19, 2021

We might want to use https://github.com/mitchellh/gon for signing and notarizing talosctl

@AlekSi
Copy link
Contributor

AlekSi commented Mar 19, 2021

I don't think we want to go down the official route because they won't accept just plopping down a binary. They want you to compile from source to be accepted in the main repo. https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae

They would accept it to https://github.com/Homebrew/homebrew-cask though

@lyda
Copy link

lyda commented Jan 24, 2023

It's kind of frustrating that go install github.com/siderolabs/talos/cmd/talosctl@latest doesn't work. With that it would be rather easy to handle brew and other packaging systems. Are the replace statements in go.mod are really needed?

@smira
Copy link
Member

smira commented Jan 25, 2023

yes, they are required. see golang/go#44840

In general, git clone (or download release sources), followed by go build should work, even though we recommend to download artifacts from our releases page.

@smira
Copy link
Member

smira commented Apr 3, 2023

@smira smira closed this as completed Apr 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants