Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leveled logging #256

Closed
andrewrynhard opened this issue Dec 2, 2018 · 3 comments
Closed

Leveled logging #256

andrewrynhard opened this issue Dec 2, 2018 · 3 comments

Comments

@andrewrynhard
Copy link
Member

Using either the standard library, or something like logrus, we should provide more robust logging.

@andrewrynhard andrewrynhard modified the milestone: v0.1.0-alpha.18 Jan 10, 2019
@andrewrynhard andrewrynhard self-assigned this Jan 25, 2019
@andrewrynhard andrewrynhard added this to the v0.1.0-alpha.17 milestone Jan 25, 2019
@andrewrynhard andrewrynhard removed this from the v0.1.0-alpha.17 milestone Feb 8, 2019
@bradbeam
Copy link
Contributor

Need to review the various log packages to weigh them

  • logrus ( ability to inject metadata with fields, native-ish syslog output )
  • zap ( fast )
  • glog / klog ( k8s uses, semi proven )
  • others(?)

Need to figure out the appropriate log structure, ex.

  • If using logrus, do we want to have a standard set of fields we apply to all messages?
  • Do we go super verbose on debug level messages to help with tracing?

Need to figure out log pattern --
Do we want to always log super verbose level, but filter/query via osctl? ( #wayfuturestate )

Once we get those pieces together, we should be able to just take on a package or so at a time and get this implemented

@smira
Copy link
Member

smira commented Apr 26, 2019

with zap, there's some ground work done to let it flow to fluentd for aggregation: https://github.com/smira/zap-msgpack-encoder

@andrewrynhard
Copy link
Member Author

Closing in favor of internal epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants