Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util-linux support #5041

Closed
BobyMCbobs opened this issue Feb 23, 2022 · 3 comments
Closed

util-linux support #5041

BobyMCbobs opened this issue Feb 23, 2022 · 3 comments

Comments

@BobyMCbobs
Copy link
Contributor

Feature Request

Include nsenter as a host program.

Description

In some cases some programs like CNI require nsenter to be on the host to operate.

Notes

Related:

@smira
Copy link
Member

smira commented Feb 24, 2022

I'm not sure I fully understand the issue. CNI runs in fact on the host, it doesn't need nsenter, as it's already in the host namespace.

If nsenter is required, it could be shipped with the CNI container (as I guess nsenter happens from some privileged container), that's how home storage provider plugins work.

I don't think we really want to ship nsenter with Talos, as certainly doing nsenter is a going backwards in terms of the security.

@michael-robbins
Copy link

Does the reply here make some sense linkerd/linkerd2#7945 (comment) possibly as to why CNI's like Linkerd require this?

Without something like this it looks like Talos wouldn't support Linkerd as a CNI?

@smira
Copy link
Member

smira commented May 19, 2022

I think we should avoid including nsenter into base Talos filesystem, but nothing stops from shipping that as a system extension for those who need that: https://github.com/siderolabs/extensions

This whole CNI story is certainly a security mess in general (not only Linkerd, but any CNI): dropping random binaries on the host, running them with basically root privileges. With Talos what one can do is to bundle CNI binaries and anything else which is required as a system extension, and install that as needed. This should allow to keep root filesystem read-only.

@smira smira closed this as completed May 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants