Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dracut style bond device selectors #8389

Open
maxpain opened this issue Mar 5, 2024 · 4 comments
Open

Support dracut style bond device selectors #8389

maxpain opened this issue Mar 5, 2024 · 4 comments

Comments

@maxpain
Copy link
Contributor

maxpain commented Mar 5, 2024

In our case, we rent a lot of dedicated servers from various hosting providers, and they provide the ability to set up an LACP bond, but after that, it's not possible to automatically provision Talos nodes because the hosting provider's switches discard ports and reject packets until the LACP bond is configured on Talos side.

As a workaround, I have to generate an ISO on https://factory.talos.dev with the following configuration:

customization:
    extraKernelArgs:
        - net.ifnames=0
        - bond=bond0:eth0,eth1,eth2,eth3:mode=802.3ad:1500

So, basically, I disable predictable network names and try to configure the LACP bond using the first 4 (or more) network interfaces.
After installing Talos, I have to reboot the machine and manually remove net.ifnames=0 from kernel args in the GRUB menu; after that, I do talosctl upgrade to save this change. For some reason, deleting net.ifnames=0 from the kernel args doesn't work when using -net.ifnames in the machineconfig.

It would be better to provide some way to configure the LACP bond on all physical network interfaces using kernel args since we have this selector in Talos 1.7:

network:
    interfaces:
    -   bond:
            deviceSelectors:
            -   physical: true
@EirikAskheim
Copy link
Contributor

Can you add a description of what and where you want these selectors?

@maxpain
Copy link
Contributor Author

maxpain commented Mar 20, 2024

@EirikAskheim done

@alexandrem
Copy link
Contributor

Isn't this available in v1.7.0 ?

@smira
Copy link
Member

smira commented Jul 18, 2024

I guess this is about kernel args - not available there atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants