Client.Push may panic

[pshopper]

Add error check on http request creation in

apns2/client.go

Line 157 in d5157a5

req, _ := http.NewRequest("POST", url, bytes.NewBuffer(payload))

and return err.

[sideshow]

Thanks @pshopper can you please provide more information such as the stack trace

[pshopper]

@sideshow

runtime.errorString: runtime error: invalid memory address or nil pointer dereference
  File "runtime/panic.go", line 489, in gopanic
    reflectcall(nil, unsafe.Pointer(d.fn), deferArgs(d), uint32(d.siz), uint32(d.siz))
  File "runtime/panic.go", line 63, in panicmem
    panic(memoryError)
  File "runtime/signal_unix.go", line 290, in sigpanic
    panicmem()
  File "server/vendor/github.com/sideshow/apns2/client.go", line 195, in setHeaders
    r.Header.Set("Content-Type", "application/json; charset=utf-8")
  File "server/vendor/github.com/sideshow/apns2/client.go", line 163, in PushWithContext
    setHeaders(req, n)
  File "server/vendor/github.com/sideshow/apns2/client.go", line 138, in Push
    return c.PushWithContext(nil, n)
  File "server/apple.go", line 248, in spawnWorker
    resp, err = client.Push(n)
  File "<autogenerated>", line 29, in spawnWorker
  File "server/delivery_provider.go", line 29, in func1
    d.spawnWorker(workerName, pm)
  File "server/vendor/github.com/getsentry/raven-go/client.go", line 753, in CapturePanic
    f()
  File "server/vendor/github.com/getsentry/raven-go/client.go", line 760, in CapturePanic
    return DefaultClient.CapturePanic(f, tags, interfaces...)

[pshopper]

It appear after set bad device token

[pshopper]

@sideshow
Maybe I will make PR?

[sideshow]

Thanks for logging this. Yes please, a PR would be great

[pshopper]

@sideshow, please, look at my PR fix(panic) fix client push panic

[sideshow]

Fixed via #134