Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for smooth on/off #164

Closed
JohanLeirnes opened this issue Nov 21, 2017 · 6 comments
Closed

Support for smooth on/off #164

JohanLeirnes opened this issue Nov 21, 2017 · 6 comments

Comments

@JohanLeirnes
Copy link

JohanLeirnes commented Nov 21, 2017

As discussed in this ticket:
#113

@JohanLeirnes
Copy link
Author

Nothing on this?

@JohanLeirnes
Copy link
Author

JohanLeirnes commented Mar 1, 2018

As a easy feature to add would be to make the OFF command send brightness to 0 wait for X ms depending on current brightness and then send OFF.
And ON command send ON then Brightness 255 if no other brightness was given.
Easy way to get a smooth on/off atleast.

This way when we turn it on to say 50 brightness it will go on and then from 1 brightness up to 50.
Not as it is now: On and then from the last brightness up/down to 50.

@sidoh
Copy link
Owner

sidoh commented Mar 1, 2018

@bhaap, I'd be happy to look at this when I've decided to set aside focused time to work on this project. As of now, I'm preoccupied with other stuff. My work on these kinds of things comes in bursts :)

I'd also be more than happy to collaborate on a PR if you're interested in taking a stab.

@JohanLeirnes
Copy link
Author

Only a novice in programming but ofcourse i can give it a stab. Could you give me some pointers on where to look in the code for sending the on and the off command (guessing its a specific place depending on bulb?)

@poudenes
Copy link

Is this still in progress? Sounds nice.. Smooth on and off.. Then my apartment will look like a mansion for outsiders :)

@sidoh
Copy link
Owner

sidoh commented Sep 1, 2019

This is now possible with transitions (documented in README).

@sidoh sidoh closed this as completed Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants