Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md5 and sha256 files are wrong on testbuilds #20

Closed
hhl opened this issue May 29, 2023 · 4 comments
Closed

md5 and sha256 files are wrong on testbuilds #20

hhl opened this issue May 29, 2023 · 4 comments
Assignees

Comments

@hhl
Copy link
Member

hhl commented May 29, 2023

We are linking our builds.date.iso to builds.latest.iso on testbuilds, also the md5 and sha256 files which is wrong, the md5/sha256 file is generated against builds.date.iso and then only linked to the new file, that doesn't work and is totally wrong!
We must generate a new builds.latest.iso.md5/sha256 file and copy this too testbuilds.

@fethomm
Copy link
Contributor

fethomm commented May 29, 2023

Good catch.

@ak-li
Copy link

ak-li commented May 29, 2023

In my opinion the checksums in the md5/sha256 files are correct. The given filename contains the build date instead of 'latest' and at the same time the relase number is missing. If the iso file is renamed, the checksum test is successful.
For example:

$ mv siduction-Masters_of_War-xfce-amd64-latest.iso siduction-22.1.2-Masters_of_War-xfce-amd64-202305281611.iso
$ sha256sum -c siduction-Masters_of_War-xfce-amd64-latest.iso.sha256
siduction-22.1.2-Masters_of_War-xfce-amd64-202305281611.iso: OK

At the same time please eliminate the md5 files. They have been considered insecure for a long time.

@towo2099
Copy link
Member

Ich habe keine ahnung, wie pyfll das macht.

@towo2099
Copy link
Member

towo2099 commented Jun 2, 2023

So, ich habe jetzt die Latest-Files komplett aus pyfll geschmissen.

@towo2099 towo2099 closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants